Differential D12276

addrman: detect on-disk corrupted nNew and nTried during unserialization
ClosedPublic
Actions

Authored by Fabien on Oct 17 2022, 14:42.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC284ea3fa5743: addrman: detect on-disk corrupted nNew and nTried during unserialization

Summary

Negative `nNew` or `nTried` are not possible during normal operation.
So, if we read such values during unserialize, report addrman corruption.

Backport of core#22455.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR22455

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20549
Build 40768: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 40767: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 17 2022, 14:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2022, 14:42

Fabien requested review of this revision.Oct 17 2022, 14:42

teamcity edited the summary of this revision. (Show Details)Oct 17 2022, 14:42

Harbormaster completed remote builds in B20549: Diff 35753.Oct 17 2022, 15:16

PiRK accepted this revision.Oct 17 2022, 15:27

This revision is now accepted and ready to land.Oct 17 2022, 15:27

Closed by commit rABC284ea3fa5743: addrman: detect on-disk corrupted nNew and nTried during unserialization (authored by Vasil Dimov <vd@FreeBSD.org>, committed by Fabien). · Explain WhyOct 17 2022, 15:29

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC284ea3fa5743: addrman: detect on-disk corrupted nNew and nTried during unserialization.

Revision Contents
Changeset List

Path

Size

src/

addrman.h

16 lines

Diff 35753

View Options

addrman: detect on-disk corrupted nNew and nTried during unserializationClosedPublicActions