Paths

Table of Contentst

Differential D12281

validation: fix CheckBlockIndex for multiple chainstates
ClosedPublic
Actions

Authored by PiRK on Oct 17 2022, 15:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC783d2807841b: validation: fix CheckBlockIndex for multiple chainstates

Summary

Adjust CheckBlockIndex to account for

assumed-valid block indexes lacking transaction data, and
setBlockIndexCandidates for the background chainstate not containing certain entries which rely on assumed-valid ancestors.

Add unittest for UpdateTip behavior

This is a backport of core#21526 [8 & 12/12]
https://github.com/bitcoin/bitcoin/pull/21526/commits/8f5710fd0ac5173b577e5d00708485170b321bcc
https://github.com/bitcoin/bitcoin/pull/21526/commits/673a5bd3377929a0a6a62eda8b560e47bc2cca0c

Depends on D12279

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 17 2022, 15:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2022, 15:16

PiRK requested review of this revision.Oct 17 2022, 15:16

teamcity edited the summary of this revision. (Show Details)Oct 17 2022, 15:16

PiRK added a child revision: D12282: test: validation: add unittest for UpdateTip behavior.Oct 17 2022, 15:23

Harbormaster completed remote builds in B20555: Diff 35762.Oct 17 2022, 16:20

There is no test, and it's not a refactor

This revision now requires changes to proceed.Oct 18 2022, 11:08

PiRK added inline comments.Oct 18 2022, 14:03

src/validation.cpp
5298 ↗	(On Diff #35762)	`pindex->pprev != nullptr` is now duplicated in the nested ifs

squash with D12282 and fix duplicated pindex->pprev != nullptr

PiRK removed a parent revision: D12280: validation: have LoadBlockIndex account for snapshot use.Oct 19 2022, 08:14

PiRK added a child revision: D12280: validation: have LoadBlockIndex account for snapshot use.

Harbormaster completed remote builds in B20598: Diff 35826.Oct 19 2022, 08:27

PiRK mentioned this in D12282: test: validation: add unittest for UpdateTip behavior.Oct 19 2022, 08:55

Fabien accepted this revision.Oct 19 2022, 10:21

Fabien added inline comments.

src/validation.cpp
5396–5414 ↗	(On Diff #35826)

This revision is now accepted and ready to land.Oct 19 2022, 10:21

refactor as per review

Harbormaster completed remote builds in B20604: Diff 35833.Oct 19 2022, 11:33

Closed by commit rABC783d2807841b: validation: fix CheckBlockIndex for multiple chainstates (authored by James O'Beirne <james.obeirne@pm.me>, committed by PiRK). · Explain WhyOct 19 2022, 11:35

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC783d2807841b: validation: fix CheckBlockIndex for multiple chainstates.

Revision Contents
Changeset List

Path

Size

src/

test/

validation_chainstate_tests.cpp

84 lines

validation.cpp

77 lines

Diff 35838

View Options

src/test/validation_chainstate_tests.cpp