Page MenuHomePhabricator
Differential D12283

[addrman] Move CAddrMan::Serialize to cpp file
ClosedPublic
Actions

Authored by Fabien on Oct 17 2022, 15:32.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC0832ac5bfddc: [addrman] Move CAddrMan::Serialize to cpp file
Summary

Partial backport of core#22740:
https://github.com/bitcoin/bitcoin/pull/22740/commits/1622543cf42feb810d8ea9e7b3238d21f1427c17

Test Plan
ninja all check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 17 2022, 15:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2022, 15:32
Fabien requested review of this revision.Oct 17 2022, 15:32
teamcity edited the summary of this revision. (Show Details)Oct 17 2022, 15:32
Fabien added a child revision: D12284: [addrman] Move CAddrMan::Unserialize to cpp file.Oct 17 2022, 15:34
PiRK accepted this revision.Oct 17 2022, 15:40
This revision is now accepted and ready to land.Oct 17 2022, 15:40
Harbormaster completed remote builds in B20557: Diff 35767.Oct 17 2022, 16:37
teamcity added a comment.Oct 17 2022, 16:37
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[344/522] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[345/522] Linking CXX executable src/bitcoin-cli
[346/522] Linking C executable src/secp256k1/recover-bench
[347/522] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[348/522] Linking C executable src/secp256k1/verify-bench
[349/522] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[350/522] Linking C executable src/secp256k1/sign-bench
[351/522] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[352/522] Linking C executable src/secp256k1/ecmult-bench
[353/522] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[354/522] Linking C executable src/secp256k1/internal-bench
[355/522] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[356/522] Linking CXX executable src/bitcoin-tx
[357/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[358/522] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[359/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[360/522] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[361/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[362/522] Building CXX object src/CMakeFiles/server.dir/txorphanage.cpp.o
[363/522] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[364/522] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[365/522] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[366/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[367/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[368/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[369/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[370/522] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[371/522] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[372/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[373/522] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[374/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[375/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[376/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[377/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[378/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[379/522] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[380/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[381/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[382/522] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[383/522] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[384/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[385/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[386/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[387/522] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[388/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[389/522] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[390/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[391/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[392/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[393/522] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[394/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[395/522] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[396/522] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[397/522] Linking CXX static library src/wallet/libwallet.a
[398/522] Linking CXX static library src/wallet/libwallet-tool.a
[399/522] Linking CXX executable src/bitcoin-wallet
[400/522] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[401/522] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
Fabien added inline comments.Oct 17 2022, 16:58
src/addrman.h
297 ↗(On Diff #35767)

Interestingly this was undetected previously and now triggers clang tidy after the move

Fabien updated this revision to Diff 35773.Oct 17 2022, 17:00

Fix clang-tidy

Harbormaster completed remote builds in B20563: Diff 35773.Oct 17 2022, 17:25
Closed by commit rABC0832ac5bfddc: [addrman] Move CAddrMan::Serialize to cpp file (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyOct 18 2022, 11:35
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC0832ac5bfddc: [addrman] Move CAddrMan::Serialize to cpp file.

Revision Contents
Changeset List

PathSize
src/
103 lines
111 lines

Diff 35784

View Options

src/addrman.h

Loading...
View Options

src/addrman.cpp

Loading...