Differential D12299

[Cashtab] [Chronik] [Tx Gen] Token transaction refactor - part 1 createToken
ClosedPublic
Actions

Authored by emack on Oct 19 2022, 07:43.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC719f5b50fa20: [Cashtab] [Chronik] [Tx Gen] Token transaction refactor - part 1 createToken

Summary

T2503

Refactor the createToken function to utilize the newly landed generateTxInput & generateTxOutput utility functions, as well as the new approach of signing input UTXOs, building tx and broadcasting via the chronik client.

At this point in the diff avoid burning tokens because that's still being broadcasted via bch-api, which will confuse chronik and result in 'Invalid SLP burns' errors when trying to create another token.

Test Plan

npm test and ensure the chronikfied unit tests all pass
npm start
create a new token with no image and ensure successful creation (check decimals, supply...) and able to be sent
verify via explorer that the XEC change (if exists) is returned to the creator
create a new token with an image and ensure successful creation (check decimals, supply...) and able to be sent

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Oct 19 2022, 07:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2022, 07:43

emack requested review of this revision.Oct 19 2022, 07:43

Harbormaster completed remote builds in B20597: Diff 35825.Oct 19 2022, 07:46

emack added a child revision: D12306: [Cashtab] [Chronik] [Tx Gen] Token transaction refactor - part 2 sendToken.Oct 19 2022, 13:30

bytesofman requested changes to this revision.Oct 19 2022, 16:41

bytesofman added inline comments.

web/cashtab/src/utils/cashMethods.js
202 ↗	(On Diff #35825)	This is needed though for SEND and BURN txs. Need to make this validation more specific.

This revision now requires changes to proceed.Oct 19 2022, 16:41

Added tokenId check and skipSlpCheck param.
The skipSlpCheck param in particular is needed here because if the wallet has existing burn txs through bch-api then chronik's safety mechanism to avoid accidental token burns will trigger and throw 'invalid-slp-burns' errors. This includes creating and sending tokens even though they have nothing to do with token burning.
Cashtab shouldn't be relying on other endpoints for validation anyway, so I don't see an issue in bypassing this.

Harbormaster completed remote builds in B20628: Diff 35874.Oct 20 2022, 07:44

bytesofman accepted this revision.Oct 24 2022, 17:08

This revision is now accepted and ready to land.Oct 24 2022, 17:08

Closed by commit rABC719f5b50fa20: [Cashtab] [Chronik] [Tx Gen] Token transaction refactor - part 1 createToken (authored by emack). · Explain WhyOct 25 2022, 06:39

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC719f5b50fa20: [Cashtab] [Chronik] [Tx Gen] Token transaction refactor - part 1 createToken.

emack mentioned this in D12306: [Cashtab] [Chronik] [Tx Gen] Token transaction refactor - part 2 sendToken.Oct 25 2022, 07:08

emack mentioned this in D12307: [Cashtab] [Chronik] [Tx Gen] Token transaction refactor - part 3 burnToken.