Page MenuHomePhabricator
Differential D12314

[Cashtab] [extension address passing p1] Move getCashtabProviderStatus function out of CashtabBase
ClosedPublic
Actions

Authored by bytesofman on Oct 19 2022, 17:08.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC42b9be5f5899: [Cashtab] [extension address passing p1] Move getCashtabProviderStatus function…
Summary

T2550

Move getCashtabProviderStatus to cashtab-helpers

This function will need to be used in a new component to get the extension's address. So, it should be moved into a separate file where it can be imported by all components, rather than live in CashtabBase.tsx

Test Plan
cd web/cashtab-components
npm run storybook

Inspect the CashtabBadge --> Standard component. The blue button should read "Cashtab Pay"
Navigate to brave://extensions and disable all Cashtab browser extensions
Reload the storybook page and inspect the CashtabBadge --> Standard component. The blue button should read "Install Cashtab & Refresh"

Diff Detail

Repository
rABC Bitcoin ABC
Branch
extension-address-passing-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20614
Build 40893: Build Diffcashtab-components-tests
Build 40892: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 19 2022, 17:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2022, 17:08
bytesofman requested review of this revision.Oct 19 2022, 17:08
Harbormaster completed remote builds in B20614: Diff 35855.Oct 19 2022, 17:11
bytesofman added a child revision: D12315: [Cashtab] [extension address passing p2] Get wallet address in ecash: format from extension version of App.js.Oct 19 2022, 17:18
emack accepted this revision.Oct 20 2022, 08:34
emack added a subscriber: emack.

FYI when going from not installed to installed, a page refresh doesn't seem to update it. Need to click onto another component before going back to Standard to see the Cashtab Pay button.

This revision is now accepted and ready to land.Oct 20 2022, 08:34
bytesofman updated this revision to Diff 35975.Oct 25 2022, 15:06

rebase

Harbormaster completed remote builds in B20692: Diff 35975.Oct 25 2022, 15:08
Closed by commit rABC42b9be5f5899: [Cashtab] [extension address passing p1] Move getCashtabProviderStatus function… (authored by bytesofman). · Explain WhyOct 27 2022, 17:10
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC42b9be5f5899: [Cashtab] [extension address passing p1] Move getCashtabProviderStatus function….

Revision Contents
Changeset List

PathSize
web/
cashtab-components/
src/
hoc/
CashtabBase/
19 lines
utils/
9 lines

Diff 35855

View Options

web/cashtab-components/src/hoc/CashtabBase/CashtabBase.tsx

Loading...
View Options

web/cashtab-components/src/utils/cashtab-helpers.ts

Loading...