[Cashtab Extension] fixed roaming nav menu when extension popped out
ClosedPublic
Actions

Authored by kieran709 on Oct 21 2022, 17:14.

Details

Reviewers

bytesofman
emack

Group Reviewers

Restricted Project

Commits

rABCce74285270d4: [Cashtab Extension] fixed roaming nav menu when extension popped out

Summary

Related to T2746 & T2743. Fixed issue with the new hamburger menu roaming in the extension when it is popped out.

Test Plan

cd web/cashtab
npm run extension
load new build
open the extension and click the pop out button from the top right corner
observe that the menu is in the correct position

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kieran709 created this revision.Oct 21 2022, 17:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2022, 17:14

kieran709 requested review of this revision.Oct 21 2022, 17:14

Harbormaster completed remote builds in B20671: Diff 35943.Oct 21 2022, 17:16

bytesofman accepted this revision.Oct 24 2022, 18:04

This revision is now accepted and ready to land.Oct 24 2022, 18:04

Closed by commit rABCce74285270d4: [Cashtab Extension] fixed roaming nav menu when extension popped out (authored by kieran709). · Explain WhyOct 24 2022, 18:46

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABCce74285270d4: [Cashtab Extension] fixed roaming nav menu when extension popped out.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

extension/

src/

components/

App.js

8 lines

Diff 35971

View Options

web/cashtab/extension/src/components/App.js

[Cashtab Extension] fixed roaming nav menu when extension popped outClosedPublicActions