Page MenuHomePhabricator
Differential D12366

[Cashtab] [bch-api deprecation p1]Remove bch-api node check from useWallet.js
ClosedPublic
Actions

Authored by bytesofman on Oct 25 2022, 17:03.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCc444787fc0f4: [Cashtab] [bch-api deprecation p1]Remove bch-api node check from useWallet.js
Summary

T2730

Remove bch-api server check from update function in useWallet.js

Now that bch-api is no longer used for utxo mgmt, tx history, or broadcasting txs, there is no point in checking on the server. It doesn't matter if it's up or down, Cashtab is not using it.

Test Plan

npm start and wallet just works

Diff Detail

Repository
rABC Bitcoin ABC
Branch
final-bch-api-deprecation
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20707
Build 41078: Build Diffcashtab-tests
Build 41077: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 25 2022, 17:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 25 2022, 17:03
bytesofman requested review of this revision.Oct 25 2022, 17:03
Harbormaster completed remote builds in B20707: Diff 35991.Oct 25 2022, 17:07
bytesofman mentioned this in D12211: [Cashtab] [Chronik] Deprecate BCH.Blockchain.getBlockCount for node health checks.Oct 25 2022, 17:49
emack accepted this revision.Oct 26 2022, 00:46
emack added a subscriber: emack.

assuming part 2 is tryNextAPI() in useWallet and past 3 is ConstructedSlpWallet in getBCH()

This revision is now accepted and ready to land.Oct 26 2022, 00:46
bytesofman updated this revision to Diff 36053.Oct 27 2022, 18:21

rebase

Harbormaster completed remote builds in B20745: Diff 36053.Oct 27 2022, 18:24
bytesofman planned changes to this revision.Nov 29 2022, 09:47

Waiting to fully deprecate BCH param before continuing with this stack.

bytesofman updated this revision to Diff 36791.Nov 29 2022, 20:56

rebase

This revision is now accepted and ready to land.Nov 29 2022, 20:56
Harbormaster completed remote builds in B21247: Diff 36791.Nov 29 2022, 20:59
bytesofman updated this revision to Diff 36868.Dec 1 2022, 08:10

rebase

Harbormaster completed remote builds in B21290: Diff 36868.Dec 1 2022, 08:24
bytesofman updated this revision to Diff 37051.Dec 7 2022, 14:30

rebase

Harbormaster completed remote builds in B21419: Diff 37051.Dec 7 2022, 14:33
bytesofman added a child revision: D12788: [Cashtab] [Cashtab] [final bch-api deprecation p2] Change chronikUrl to chronikUrls array.Dec 7 2022, 14:38
Closed by commit rABCc444787fc0f4: [Cashtab] [bch-api deprecation p1]Remove bch-api node check from useWallet.js (authored by bytesofman). · Explain WhyDec 8 2022, 03:53
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCc444787fc0f4: [Cashtab] [bch-api deprecation p1]Remove bch-api node check from useWallet.js.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
11 lines

Diff 35991

View Options

web/cashtab/src/hooks/useWallet.js

Loading...