Page MenuHomePhabricator
Differential D12369

[Cashtab] Rename WalletInfo Component in Receive.js
ClosedPublic
Actions

Authored by kieran709 on Oct 25 2022, 17:42.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC23af147f7dfe: [Cashtab] Rename WalletInfo Component in Receive.js
Summary

Related to T2742. The WalletInfo component is misnamed, has been renamed to ReceiveWithWalletPresent to more closely reflect what this component is.

Test Plan

cd web/cashtab && npm start
navigate to the receive page, observe nothing has changed
in a private browser, navigate to localhost:3000/#/receive
navigate to the receive page, observe that nothing has changed

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rename-walletInfo-component
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20711
Build 41086: Build Diffcashtab-tests
Build 41085: arc lint + arc unit

Event Timeline

kieran709 created this revision.Oct 25 2022, 17:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 25 2022, 17:42
kieran709 requested review of this revision.Oct 25 2022, 17:42
bytesofman requested changes to this revision.Oct 25 2022, 17:56
bytesofman added inline comments.
web/cashtab/src/components/Receive/Receive.js
55

Just call it 'Receive'

This revision now requires changes to proceed.Oct 25 2022, 17:56
bytesofman accepted this revision.Oct 25 2022, 17:56
bytesofman added inline comments.
web/cashtab/src/components/Receive/Receive.js
55

oh nm I see this would conflict with the overall export.

This is fine

This revision is now accepted and ready to land.Oct 25 2022, 17:56
Harbormaster completed remote builds in B20711: Diff 35997.Oct 25 2022, 18:02
Closed by commit rABC23af147f7dfe: [Cashtab] Rename WalletInfo Component in Receive.js (authored by kieran709). · Explain WhyOct 25 2022, 20:00
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABC23af147f7dfe: [Cashtab] Rename WalletInfo Component in Receive.js.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Receive/
4 lines

Diff 35997

View Options

web/cashtab/src/components/Receive/Receive.js

Loading...