T2730
Depends on D12376
Replace the BCH method in the calcFee function. This means that BCH is no longer an input parameter to calcFee, so it is removed in all function calls.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC68ca3319a696: [Cashtab] [p2 remove BCH.getByteCount] Replace BCH.getByteCount in calcFee
Review updated function and npm test. Note that the existing unit test for calcFee still passes.
grep -r calcFee web/cashtab/src. Confirm that all calls to calcFee have had the BCH parameter removed.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- replace-getbytecount
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20730 Build 41124: Build Diff cashtab-tests Build 41123: arc lint + arc unit