Differential D12387

[Cashtab] [BCH deprecation] Pt 1/2 - Implement local isCashAddress validation logic
ClosedPublic
Actions

Authored by emack on Oct 28 2022, 12:15.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Summary

T2370

As a prerequisite to deprecating BCH.Address.isCashAddress, this diff implements a local function to replicate this validation.

Test Plan

npm test and ensure unit tests passes
npm start
send a simple XEC tx and observe the 'change address parsing in bchJsCheck matches localCheck' console log is displayed

Diff Detail

Repository

rABC Bitcoin ABC

Branch

deprecateIsCashAddress

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20752
Build 41168: Build Diff	cashtab-tests
Build 41167: arc lint + arc unit

Event Timeline

emack created this revision.Oct 28 2022, 12:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 28 2022, 12:15

emack requested review of this revision.Oct 28 2022, 12:15

emack retitled this revision from [Cashtab] Part 1 - Implement local isCashAddress validation logic to [Cashtab] [BCH deprecation] Part 1 - Implement local isCashAddress validation logic.Oct 28 2022, 12:16

Harbormaster completed remote builds in B20752: Diff 36060.Oct 28 2022, 12:20

emack retitled this revision from [Cashtab] [BCH deprecation] Part 1 - Implement local isCashAddress validation logic to [Cashtab] [BCH deprecation] Pt 1/2 - Implement local isCashAddress validation logic.Oct 28 2022, 12:26

emack added a child revision: D12388: [Cashtab] [BCH deprecation] Pt 2/2 - Deprecate BCH.Address.isCashAddress from cashMethods.Oct 28 2022, 12:28

bytesofman accepted this revision.Oct 28 2022, 16:36

This revision is now accepted and ready to land.Oct 28 2022, 16:36

Merged and landed via D12388