Paths

Table of Contentst

Differential D12404

[Cashtab] Patch balance toggle initializing hidden
ClosedPublic
Actions

Authored by kieran709 on Oct 31 2022, 22:43.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC17c2034b0547: [Cashtab] Patch balance toggle initializing hidden

Summary

Related to T2765. Renamed toggleHideBalance to toggleBalanceVisibility as it better describes the setting's purpose. Initialized toggleBalanceVisibility as true. Updated unit tests to reflect the change to default settings.

Test Plan

cd web/cashtab && npm start
using a private browser window to ensure default settings
import a wallet
observe that the balance visibility toggle is true, and that the balance is visible
toggle balance visibility off and observe that the setting persists across all screens

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kieran709 created this revision.Oct 31 2022, 22:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2022, 22:43

kieran709 requested review of this revision.Oct 31 2022, 22:43

bytesofman requested changes to this revision.Oct 31 2022, 22:45

bytesofman added inline comments.

web/cashtab/src/components/Common/Ticker.js
88 ↗	(On Diff #36092)	this is still confusing change `toggleBalanceVisibility` to `balanceVisible`

This revision now requires changes to proceed.Oct 31 2022, 22:45

Harbormaster completed remote builds in B20779: Diff 36092.Oct 31 2022, 22:46

responding to review feedback

Harbormaster completed remote builds in B20780: Diff 36093.Oct 31 2022, 22:51

bytesofman accepted this revision.Oct 31 2022, 22:57

This revision is now accepted and ready to land.Oct 31 2022, 22:57

Closed by commit rABC17c2034b0547: [Cashtab] Patch balance toggle initializing hidden (authored by kieran709). · Explain WhyOct 31 2022, 22:58

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABC17c2034b0547: [Cashtab] Patch balance toggle initializing hidden.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Common/

BalanceHeader.js

2 lines

BalanceHeaderFiat.js

2 lines

HideBalanceSwitch.js

6 lines

4 lines

hooks/

2 lines

utils/

__tests__/

validation.test.js

10 lines

Diff 36094

web/cashtab/src/components/Common/BalanceHeader.js

Loading...

web/cashtab/src/components/Common/BalanceHeaderFiat.js

Loading...

web/cashtab/src/components/Common/HideBalanceSwitch.js

Loading...

web/cashtab/src/components/Common/Ticker.js

Loading...

web/cashtab/src/hooks/useWallet.js

Loading...

web/cashtab/src/utils/tests/validation.test.js

Loading...