Page MenuHomePhabricator

[Cashtab] Patch balance toggle initializing hidden
ClosedPublic

Authored by kieran709 on Oct 31 2022, 22:43.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC17c2034b0547: [Cashtab] Patch balance toggle initializing hidden
Summary

Related to T2765. Renamed toggleHideBalance to toggleBalanceVisibility as it better describes the setting's purpose. Initialized toggleBalanceVisibility as true. Updated unit tests to reflect the change to default settings.

Test Plan

cd web/cashtab && npm start
using a private browser window to ensure default settings
import a wallet
observe that the balance visibility toggle is true, and that the balance is visible
toggle balance visibility off and observe that the setting persists across all screens

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-balance-toggle-initializing-hidden
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20779
Build 41220: Build Diffcashtab-tests
Build 41219: arc lint + arc unit

Event Timeline

bytesofman added inline comments.
web/cashtab/src/components/Common/Ticker.js
88

this is still confusing

change toggleBalanceVisibility to balanceVisible

This revision now requires changes to proceed.Oct 31 2022, 22:45

responding to review feedback

This revision is now accepted and ready to land.Oct 31 2022, 22:57