Differential D12428

[Cashtab][Pt 2/4] Move message signing and verification to new screen - Remove Verification & Signing from Send.js
ClosedPublic
Actions

Authored by kieran709 on Nov 7 2022, 17:44.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC0d347bd988d3: [Cashtab][Pt 2/4] Move message signing and verification to new screen - Remove…

Summary

Related to T2734, depends on D12426. Message signing and verification collapses should be on their on screen. Part 2 of this diff is the removal of these collapses from Send.js

Test Plan

cd web/cashtab && npm start
navigate to the Send screen
observe that the message verification and signing collapses are no longer present

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kieran709 created this revision.Nov 7 2022, 17:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 7 2022, 17:44

kieran709 requested review of this revision.Nov 7 2022, 17:44

Harbormaster completed remote builds in B20820: Diff 36153.Nov 7 2022, 17:47

kieran709 added a child revision: D12430: [Cashtab][Pt 3/4] Move message signing and verification to new screen - create new SignVerifyMsg component.Nov 7 2022, 18:24

bytesofman accepted this revision.Nov 8 2022, 17:03

This revision is now accepted and ready to land.Nov 8 2022, 17:03

Closed by commit rABC0d347bd988d3: [Cashtab][Pt 2/4] Move message signing and verification to new screen - Remove… (authored by kieran709). · Explain WhyNov 8 2022, 17:26

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABC0d347bd988d3: [Cashtab][Pt 2/4] Move message signing and verification to new screen - Remove….

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Send/

Send.js

375 lines

__tests__/

__snapshots__/

Send.test.js.snap

Diff 36173

View Options

web/cashtab/src/components/Send/Send.js

View Options

web/cashtab/src/components/Send/tests/snapshots/Send.test.js.snap

[Cashtab][Pt 2/4] Move message signing and verification to new screen - Remove Verification & Signing from Send.jsClosedPublicActions