Differential D12437

test: use MiniWallet for p2p_blocksonly.py
ClosedPublic
Actions

Authored by Fabien on Nov 8 2022, 16:48.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCe3e2055a0506: test: use MiniWallet for p2p_blocksonly.py

Summary

This test can now be run even with the wallet disabled.

Backport of core#21867.

Depends on D12436.

Test Plan

With and without wallet:

./test/functional/test_runner.py p2p_blocksonly

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR21867

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20831
Build 41321: Build Diff	build-without-wallet · build-debug · build-diff · build-clang · build-clang-tidy
Build 41320: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 8 2022, 16:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 8 2022, 16:48

Fabien requested review of this revision.Nov 8 2022, 16:48

teamcity edited the summary of this revision. (Show Details)Nov 8 2022, 16:48

Harbormaster completed remote builds in B20831: Diff 36169.Nov 8 2022, 17:00

sdulfari accepted this revision.Nov 8 2022, 18:25

This revision is now accepted and ready to land.Nov 8 2022, 18:25

Fabien added a child revision: D12449: p2p: Rename fBlocksOnly, Add test.Nov 9 2022, 20:59

Closed by commit rABCe3e2055a0506: test: use MiniWallet for p2p_blocksonly.py (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by Fabien). · Explain WhyNov 10 2022, 07:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe3e2055a0506: test: use MiniWallet for p2p_blocksonly.py.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_blocksonly.py

27 lines

Diff 36169

View Options

test/functional/p2p_blocksonly.py

test: use MiniWallet for p2p_blocksonly.pyClosedPublicActions