Differential D12439

[Cashtab] Patched vertical alignment of NavItems in hamburger menu
ClosedPublic
Actions

Authored by kieran709 on Nov 8 2022, 22:41.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCf905533957e2: [Cashtab] Patched vertical alignment of NavItems in hamburger menu

Summary

Related to T2775. Patched vertical alignment of NavItem text and icons.

Test Plan

cd web/casthab && npm start
open the hamburger menu
observe that the NavItem text and NavItem icons are centered vertically.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

patch-NavItem-vertical-alignment

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20833
Build 41324: Build Diff	cashtab-tests
Build 41323: arc lint + arc unit

Event Timeline

kieran709 created this revision.Nov 8 2022, 22:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 8 2022, 22:41

kieran709 requested review of this revision.Nov 8 2022, 22:41

Harbormaster completed remote builds in B20833: Diff 36176.Nov 8 2022, 22:44

bytesofman accepted this revision.Nov 8 2022, 22:56

This revision is now accepted and ready to land.Nov 8 2022, 22:56

Closed by commit rABCf905533957e2: [Cashtab] Patched vertical alignment of NavItems in hamburger menu (authored by kieran709). · Explain WhyNov 8 2022, 23:00

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABCf905533957e2: [Cashtab] Patched vertical alignment of NavItems in hamburger menu.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

App.js

2 lines

Diff 36176

View Options

web/cashtab/src/components/App.js

[Cashtab] Patched vertical alignment of NavItems in hamburger menuClosedPublicActions