Differential D12444

Improve the getblock test in rpc_blockchain
ClosedPublic
Actions

Authored by Fabien on Nov 9 2022, 12:49.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC3e5ce6af598a: Improve the getblock test in rpc_blockchain

Summary

This diff removes the need for both the txindex and the wallet from the _test_getblock test. This will make it possible to run the test with no wallet in a later backport. Note that this test case is ABC only.

Test Plan

./test/functional/test_runner.py rpc_blockchain

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 9 2022, 12:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2022, 12:49

Fabien requested review of this revision.Nov 9 2022, 12:49

Harbormaster completed remote builds in B20845: Diff 36191.Nov 9 2022, 13:10

PiRK accepted this revision.Nov 9 2022, 14:15

This revision is now accepted and ready to land.Nov 9 2022, 14:15

Closed by commit rABC3e5ce6af598a: Improve the getblock test in rpc_blockchain (authored by Fabien). · Explain WhyNov 9 2022, 14:39

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3e5ce6af598a: Improve the getblock test in rpc_blockchain.

Revision Contents
Changeset List

Path

Size

test/

functional/

rpc_blockchain.py

17 lines

Diff 36196

View Options

test/functional/rpc_blockchain.py

Improve the getblock test in rpc_blockchainClosedPublicActions