Differential D12452

[Cashtab] [BCH Deprecation] [Mnemonic] Pt 3/7 - Implement BCH.Mnemonic.wordLists locally
ClosedPublic
Actions

Authored by emack on Nov 10 2022, 07:28.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCd43065fdc871: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 3/7 - Implement BCH.Mnemonic.

Summary

T2730

Depends on D12451

Stacked diff to localize existing uses of BCH.Mnemonic throughout the app and deprecate the BCH.Mnemonic object.

Pt 1/7 - Implement BCH.Mnemonic.toSeed locally
Pt 2/7 - Implement BCH.Mnemonic.generate locally
Pt 3/7 - Implement BCH.Mnemonic.wordLists locally
Pt 4/7 - Implement BCH.Mnemonic.validate locally
Pt 5/7 - Deprecate BCH.Mnemonic throughout the app
Pt 6/7 - Optimize bip39 bundle via webpack IgnorePlugin
Pt 7/7 - Unwrap validateMnemonicWordList

Test Plan

npm test
npm start
create a new wallet and observe the 'bip39 wordlists matches BCH.Mnemonic wordlists' console log message
import a wallet and observe the same console log message

Diff Detail

Repository

rABC Bitcoin ABC

Branch

mnemonic

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20858
Build 41373: Build Diff	cashtab-tests
Build 41372: arc lint + arc unit

Event Timeline

emack created this revision.Nov 10 2022, 07:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2022, 07:28

emack requested review of this revision.Nov 10 2022, 07:28

Harbormaster completed remote builds in B20858: Diff 36206.Nov 10 2022, 07:31

Green with a nit -- we should implement bip39 with only the english word list. See discussion in README at https://www.npmjs.com/package/bip39

The webpack approach is probably the best for Cashtab. Please add a part 6 to this stack to do this.

This revision is now accepted and ready to land.Nov 10 2022, 10:03

emack added a child revision: D12466: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 4/7 - Implement BCH.Mnemonic.validate locally.Nov 10 2022, 12:57

emack retitled this revision from [Cashtab] [BCH Deprecation] [Mnemonic] Pt 3/5 - Implement BCH.Mnemonic.wordLists locally to [Cashtab] [BCH Deprecation] [Mnemonic] Pt 3/6 - Implement BCH.Mnemonic.wordLists locally.Nov 10 2022, 12:59

emack edited the summary of this revision. (Show Details)

emack retitled this revision from [Cashtab] [BCH Deprecation] [Mnemonic] Pt 3/6 - Implement BCH.Mnemonic.wordLists locally to [Cashtab] [BCH Deprecation] [Mnemonic] Pt 3/7 - Implement BCH.Mnemonic.wordLists locally.Nov 14 2022, 12:06

emack edited the summary of this revision. (Show Details)

rebase

Harbormaster completed remote builds in B20996: Diff 36413.Nov 20 2022, 00:24

Closed by commit rABCd43065fdc871: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 3/7 - Implement BCH.Mnemonic. (authored by emack). · Explain WhyNov 22 2022, 21:49

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABCd43065fdc871: [Cashtab] [BCH Deprecation] [Mnemonic] Pt 3/7 - Implement BCH.Mnemonic..