cover DisconnectBlock with lock annotation
ClosedPublic
Actions

Authored by PiRK on Nov 10 2022, 09:05.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc2a48fe20b60: cover DisconnectBlock with lock annotation

Summary

CoinsTip() access requires cs_main and therefore so should this function.

This is a backport of core#23661

Test Plan

With clang + DEBUG
ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 10 2022, 09:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2022, 09:05

PiRK requested review of this revision.Nov 10 2022, 09:05

teamcity edited the summary of this revision. (Show Details)Nov 10 2022, 09:05

Harbormaster completed remote builds in B20863: Diff 36220.Nov 10 2022, 09:42

Fabien accepted this revision.Nov 10 2022, 14:01

This revision is now accepted and ready to land.Nov 10 2022, 14:01

Closed by commit rABCc2a48fe20b60: cover DisconnectBlock with lock annotation (authored by James O'Beirne <james.obeirne@pm.me>, committed by PiRK). · Explain WhyNov 10 2022, 15:06

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc2a48fe20b60: cover DisconnectBlock with lock annotation.

Revision Contents
Changeset List

Path

Size

src/

validation.h

3 lines

validation.cpp

1 line

Diff 36242

View Options

src/validation.h