Page MenuHomePhabricator
Differential D12457

Remove CTxMemPool params from ATMP
ClosedPublic
Actions

Authored by PiRK on Nov 10 2022, 09:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC448a91fef4e4: Remove CTxMemPool params from ATMP
Summary

Co-authored-by: John Newbery <1063656+jnewbery@users.noreply.github.com>
Co-authored-by: Jon Atack <jon@atack.com>

This is a backport of core#23465

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Nov 10 2022, 09:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2022, 09:28
PiRK requested review of this revision.Nov 10 2022, 09:28
teamcity edited the summary of this revision. (Show Details)Nov 10 2022, 09:28
Harbormaster completed remote builds in B20864: Diff 36221.Nov 10 2022, 09:46
Fabien requested changes to this revision.Nov 10 2022, 14:11
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validation.cpp
5741

If removing the spaces is useful you should do it here as well. If not then keep the spaces in both places (this is a clang-tidy syntax)

This revision now requires changes to proceed.Nov 10 2022, 14:11
PiRK updated this revision to Diff 36243.Nov 10 2022, 15:17

consistency in named parameter documentation syntax: no spaces

Harbormaster completed remote builds in B20881: Diff 36243.Nov 10 2022, 15:42
Fabien accepted this revision.Nov 10 2022, 15:44
This revision is now accepted and ready to land.Nov 10 2022, 15:44
Closed by commit rABC448a91fef4e4: Remove CTxMemPool params from ATMP (authored by lsilva01 <lsilva01@protonmail.com>, committed by PiRK). · Explain WhyNov 11 2022, 03:31
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC448a91fef4e4: Remove CTxMemPool params from ATMP.

Revision Contents
Changeset List

PathSize
src/
6 lines
16 lines
23 lines

Diff 36221

View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...