Page MenuHomePhabricator

[Cashtab] [BCH Deprecation] [HD Node] Pt 3/3 - Deprecate BCH.HDNode
ClosedPublic

Authored by emack on Nov 10 2022, 13:26.

Details

Summary

T2730

Depends on D12447

This is part 3 of the 3 part diff that fully deprecates the use of the BCH.HDNode object.

Pt 1/3 - Implement separate masterHDNode creation logic
Pt 2/3 - Localize downstream logic from masterHDNode
Pt 3/3 - Deprecate BCH.HDNode

Test Plan

grep -r 'BCH.HDNode' src/ and ensure no hits
npm test
npm start
create new wallet
send and receive XEC with the new wallet's ecash address
send and receive encrypted messages to test the funding WIF extraction logic

Diff Detail

Repository
rABC Bitcoin ABC
Branch
masterHdNode
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20877
Build 41411: Build Diffcashtab-tests
Build 41410: arc lint + arc unit