Page MenuHomePhabricator
Differential D12478

scripted-diff: Use generate* from TestFramework
ClosedPublic
Actions

Authored by Fabien on Nov 11 2022, 15:28.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC7ef04668cc29: scripted-diff: Use generate* from TestFramework
Summary

Backport of core#22788.

Depends on D12477.

Test Plan
ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 11 2022, 15:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2022, 15:28
Fabien requested review of this revision.Nov 11 2022, 15:28
teamcity edited the summary of this revision. (Show Details)Nov 11 2022, 15:28
Harbormaster completed remote builds in B20891: Diff 36259.Nov 11 2022, 15:40
PiRK added a subscriber: PiRK.Nov 12 2022, 08:46
PiRK added inline comments.
doc/test-shell.md
98 ↗(On Diff #36259)

That is redundant.

PiRK accepted this revision.Nov 12 2022, 09:02
This revision is now accepted and ready to land.Nov 12 2022, 09:02
Fabien added inline comments.Nov 12 2022, 12:50
doc/test-shell.md
98 ↗(On Diff #36259)

Good catch

Fabien added inline comments.Nov 12 2022, 12:52
doc/test-shell.md
98 ↗(On Diff #36259)

it's also wrong, should be test.generatetoaddress(test.nodes[0], 101, address)

Closed by commit rABC7ef04668cc29: scripted-diff: Use generate* from TestFramework (authored by Fabien). · Explain WhyNov 12 2022, 12:52
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC7ef04668cc29: scripted-diff: Use generate* from TestFramework.

Large Diff

This large diff affects 123 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
doc/
2 lines
test/
functional/
39 lines
4 lines
2 lines
3 lines
64 lines
6 lines
3 lines
2 lines
2 lines
9 lines
6 lines
2 lines
4 lines
10 lines
8 lines
8 lines
2 lines
17 lines
2 lines
8 lines
2 lines
8 lines
6 lines
2 lines
6 lines
2 lines
6 lines
16 lines
8 lines
4 lines
4 lines
18 lines
7 lines
2 lines
2 lines
2 lines
8 lines
21 lines
12 lines
4 lines
8 lines
6 lines
16 lines
34 lines
4 lines
4 lines
18 lines
8 lines
2 lines
4 lines
10 lines
2 lines
2 lines
2 lines
14 lines
4 lines
4 lines
6 lines
2 lines
16 lines
4 lines
4 lines
13 lines
8 lines
2 lines
2 lines
3 lines
3 lines
4 lines
2 lines
4 lines
8 lines
2 lines
16 lines
10 lines
8 lines
2 lines
2 lines
24 lines
33 lines
4 lines
6 lines
8 lines
20 lines
4 lines
4 lines
12 lines
10 lines
22 lines
6 lines
2 lines
8 lines
2 lines
6 lines
4 lines
20 lines
12 lines
17 lines
41 lines
6 lines
4 lines
2 lines
6 lines
2 lines
16 lines
12 lines
6 lines
4 lines
20 lines
8 lines
2 lines
6 lines
24 lines
10 lines
22 lines
6 lines
9 lines
14 lines
8 lines
7 lines
7 lines
4 lines

Diff 36263

View Options

doc/test-shell.md

View Options

test/functional/abc-finalize-block.py

View Options

test/functional/abc-get-invalid-block.py

View Options

test/functional/abc-magnetic-anomaly-mining.py

View Options

test/functional/abc-minimaldata.py

View Options

test/functional/abc-parkedchain.py

View Options

test/functional/abc-schnorr.py

View Options

test/functional/abc-schnorrmultisig.py

View Options

test/functional/abc_feature_minerfund.py

View Options

test/functional/abc_feature_proof_cleanup.py

View Options

test/functional/abc_p2p_avalanche_peer_discovery.py

View Options

test/functional/abc_p2p_avalanche_proof_voting.py

View Options

test/functional/abc_p2p_avalanche_quorum.py

View Options

test/functional/abc_p2p_avalanche_transaction_voting.py

View Options

test/functional/abc_p2p_avalanche_voting.py

View Options

test/functional/abc_p2p_getavaaddr.py

View Options

test/functional/abc_p2p_proof_inventory.py

View Options

test/functional/abc_rpc_addavalanchenode.py

View Options

test/functional/abc_rpc_avalancheproof.py

View Options

test/functional/abc_rpc_buildavalancheproof.py

View Options

test/functional/abc_rpc_getavalancheinfo.py

View Options

test/functional/abc_rpc_getavalanchepeerinfo.py

View Options

test/functional/abc_rpc_getavalancheproofs.py

View Options

test/functional/abc_rpc_isfinal.py

View Options

test/functional/abc_wallet_dumpcoins.py

View Options

test/functional/abc_wallet_standardness.py

View Options

test/functional/example_test.py

View Options

test/functional/feature_abortnode.py

View Options

test/functional/feature_bip68_sequence.py

View Options

test/functional/feature_blockfilterindex_prune.py

View Options

test/functional/feature_blocksdir.py

View Options

test/functional/feature_cltv.py

View Options

test/functional/feature_coinstatsindex.py

View Options

test/functional/feature_csv_activation.py

View Options

test/functional/feature_dersig.py

View Options

test/functional/feature_loadblock.py

View Options

test/functional/feature_maxuploadtarget.py

View Options

test/functional/feature_minchainwork.py

View Options

test/functional/feature_notifications.py

View Options

test/functional/feature_pruning.py

View Options

test/functional/feature_reindex.py

View Options

test/functional/feature_utxo_set_hash.py

View Options

test/functional/interface_bitcoin_cli.py

View Options

test/functional/interface_rest.py

View Options

test/functional/interface_zmq.py

View Options

test/functional/mempool_accept.py

View Options

test/functional/mempool_expiry.py

View Options

test/functional/mempool_package_limits.py

View Options

test/functional/mempool_packages.py

View Options

test/functional/mempool_persist.py

View Options

test/functional/mempool_reorg.py

View Options

test/functional/mempool_resurrect.py

View Options

test/functional/mempool_spend_coinbase.py

View Options

test/functional/mempool_unbroadcast.py

View Options

test/functional/mempool_updatefromblock.py

View Options

test/functional/mining_basic.py

View Options

test/functional/mining_getblocktemplate_longpoll.py

View Options

test/functional/mining_prioritisetransaction.py

View Options

test/functional/p2p_blockfilters.py

View Options

test/functional/p2p_blocksonly.py

View Options

test/functional/p2p_compactblocks.py

View Options

test/functional/p2p_eviction.py

View Options

test/functional/p2p_feefilter.py

View Options

test/functional/p2p_filter.py

View Options

test/functional/p2p_fingerprint.py

View Options

test/functional/p2p_ibd_txrelay.py

View Options

test/functional/p2p_inv_download.py

View Options

test/functional/p2p_invalid_block.py

View Options

test/functional/p2p_invalid_locator.py

View Options

test/functional/p2p_invalid_tx.py

View Options

test/functional/p2p_leak.py

View Options

test/functional/p2p_leak_tx.py

View Options

test/functional/p2p_node_network_limited.py

View Options

test/functional/p2p_permissions.py

View Options

test/functional/p2p_sendheaders.py

View Options

test/functional/rpc_blockchain.py

View Options

test/functional/rpc_createmultisig.py

View Options

test/functional/rpc_dumptxoutset.py

View Options

test/functional/rpc_estimatefee.py

View Options

test/functional/rpc_fundrawtransaction.py

View Options

test/functional/rpc_generateblock.py

View Options

test/functional/rpc_getblockfilter.py

View Options

test/functional/rpc_getblockstats.py

View Options

test/functional/rpc_getchaintips.py

View Options

test/functional/rpc_invalidateblock.py

View Options

test/functional/rpc_net.py

View Options

test/functional/rpc_packages.py

View Options

test/functional/rpc_preciousblock.py

View Options

test/functional/rpc_psbt.py

View Options

test/functional/rpc_rawtransaction.py

View Options

test/functional/rpc_scantxoutset.py

View Options

test/functional/rpc_signrawtransaction.py

View Options

test/functional/rpc_txoutproof.py

View Options

test/functional/tool_wallet.py

View Options

test/functional/wallet_abandonconflict.py

View Options

test/functional/wallet_address_types.py

View Options

test/functional/wallet_avoidreuse.py

View Options

test/functional/wallet_backup.py

View Options

test/functional/wallet_balance.py

View Options

test/functional/wallet_basic.py

View Options

test/functional/wallet_coinbase_category.py

View Options

test/functional/wallet_create_tx.py

View Options

test/functional/wallet_createwallet.py

View Options

test/functional/wallet_disable.py

View Options

test/functional/wallet_dump.py

View Options

test/functional/wallet_groups.py

View Options

test/functional/wallet_hd.py

View Options

test/functional/wallet_import_rescan.py

View Options

test/functional/wallet_importdescriptors.py

View Options

test/functional/wallet_importmulti.py

View Options

test/functional/wallet_importprunedfunds.py

View Options

test/functional/wallet_keypool.py

View Options

test/functional/wallet_keypool_topup.py

View Options

test/functional/wallet_labels.py

View Options

test/functional/wallet_listreceivedby.py

View Options

test/functional/wallet_listsinceblock.py

View Options

test/functional/wallet_listtransactions.py

View Options

test/functional/wallet_multiwallet.py

View Options

test/functional/wallet_reorgsrestore.py

View Options

test/functional/wallet_send.py

View Options

test/functional/wallet_txn_clone.py

View Options

test/functional/wallet_txn_doublespend.py

View Options

test/functional/wallet_watchonly.py