T2784
Depends on D12496
Remove segwit support from the xecjs-message library. Test the async signing function in Cashtab to verify that segwit removal did not break any modified functions.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project
npm start
Sign a message
Confirm dev log displays 'Both methods not broken'
Verify a message
Confirm verification
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- local-ecpair
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 20941 Build 41538: Build Diff cashtab-tests Build 41537: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
Tx.js | 35.71 | 0 | 0 | 35.71 | 48,54,58-60,64,69-71,79,86-88,92,112-126,138-145,155-203,211-223,228,234,239,246-248,265-273,288,320,323,337,353,375,383-392,409,413,436-963 TxHistory.js | 80 | 100 | 50 | 80 | 19 src/components/OnBoarding | 50 | 8.33 | 35.71 | 51.61 | OnBoarding.js | 50 | 8.33 | 35.71 | 51.61 | 57-68,72-92,122-158 src/components/Receive | 86.95 | 62.96 | 72.72 | 86.95 | Receive.js | 86.95 | 62.96 | 72.72 | 86.95 | 70,135-141 src/components/Send | 30.07 | 33.22 | 26.92 | 30.85 | Send.js | 27.06 | 36.72 | 15.38 | 28.36 | 57,135-139,143-149,154-155,159,183,191,204-217,229-394,400-455,462-522,529-531,538-548,556-577,611,698-955 SendToken.js | 33.91 | 28.67 | 38.46 | 33.92 | 151,157-214,219-243,250-287,295-306,313-317,322-323,327,331-340,344-396,401-408,412-413,432,436,466-736,783 src/components/SignVerifyMsg | 0 | 0 | 0 | 0 | SignVerifyMsg.js | 0 | 0 | 0 | 0 | 26-467 src/components/Tokens | 29.18 | 27.41 | 17.64 | 29.43 | CreateTokenForm.js | 24.42 | 24.56 | 12.76 | 24.65 | 95,99-128,133,137-221,226-244,249-255,268-284,296-313,321-331,339-344,353-356,380-431,439-502,510-743,779-826,849 TokenIcon.js | 100 | 100 | 100 | 100 | Tokens.js | 92.3 | 60 | 66.66 | 92.3 | 110 src/hooks | 24.97 | 20.98 | 28.18 | 25.56 | useBCH.js | 51.33 | 50 | 75 | 52.02 | 95-99,106,108,110,115,128-207,222,239-287,304-357,392-395,413,435-436,509,520,522,524,529,539-542 useImage.js | 0 | 0 | 0 | 0 | 1-199 useInnerScroll.js | 0 | 100 | 0 | 0 | 3-6 useInterval.js | 88.88 | 50 | 80 | 87.5 | 16 usePrevious.js | 100 | 100 | 100 | 100 | useWallet.js | 23.21 | 14.47 | 33.33 | 23.76 | 75-102,135-139,152-277,287-288,294-301,305-313,329-333,349-355,370,406-409,416-423,429-434,443-469,480-500,510-616,622-656,662-701,710-747,752-801,805-831,840-850,857-958,980-1070,1091-1115,1132-1143,1162-1173,1183-1188,1193,1199-1246,1263,1288-1359,1372-1378,1396-1414,1457-1480 useWebAuthentication.js | 1.47 | 0 | 0 | 1.51 | 12-235 useWindowDimensions.js | 77.77 | 100 | 60 | 87.5 | 21 src/utils | 82.7 | 81.52 | 71.2 | 82.87 | GoogleAnalytics.js | 22.72 | 0 | 0 | 23.8 | 9-39,54-59,63 cashMethods.js | 93.83 | 90.9 | 100 | 93.69 | 91-93,137,230,259,288-289,377,413,458,629-630,728,739,957,977,986,1009,1050,1090,1104,1131,1152-1155,1181-1182 chronik.js | 72.86 | 82.1 | 57.14 | 73.12 | 66-84,93-103,115-127,188,218,292,408-417,501-503,532-535,564-565,597-603,622-625,637,644-645,720-729,784-898,941-942 coininfo.js | 65.21 | 20 | 50 | 65.21 | 21-26,54-58 context.js | 60 | 100 | 0 | 60 | 9-10,22-23 convertArrBuffBase64.js | 20 | 100 | 0 | 22.22 | 3-10,15-18 debounce.js | 0 | 0 | 0 | 0 | 4-8 ecashCoinInfo.js | 100 | 100 | 100 | 100 | formatting.js | 77.77 | 83.33 | 100 | 77.77 | 15,25,43,53,68-70,109-111 retry.js | 0 | 0 | 0 | 0 | 1-8 tokenMethods.js | 100 | 100 | 100 | 100 | validation.js | 94.21 | 80.76 | 84 | 94.04 | 58-65,102-109,213,259,309,321 src/utils/icons | 2.52 | 0 | 0 | 2.72 | cropImage.js | 2.27 | 0 | 0 | 2.43 | 2-78 resizeImage.js | 2.77 | 0 | 0 | 3.03 | 2-51 roundImage.js | 2.56 | 0 | 0 | 2.77 | 2-57 ---------------------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- ##teamcity[blockOpened name='Code Coverage Summary'] ##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='1889'] ##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='4342'] ##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='818'] ##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='2109'] ##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='315'] ##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='965'] ##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='1858'] ##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='4241'] ##teamcity[blockClosed name='Code Coverage Summary'] Test Suites: 1 failed, 19 passed, 20 total Tests: 399 passed, 399 total Snapshots: 33 passed, 33 total Time: 12.606 s Ran all test suites. Build cashtab-tests failed with exit code 1