Page MenuHomePhabricator
Differential D1250

Enable benchmark building by default and fix benchmarks for gcc 6+
ClosedPublic
Actions

Authored by deadalnix on Apr 6 2018, 22:54.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING4642a5e9b468: Enable benchmark building by default and fix benchmarks for gcc 6+
rABC4642a5e9b468: Enable benchmark building by default and fix benchmarks for gcc 6+
Summary

As per title. this is backport of upstream PR480 and PR490 by Pieter Wuille.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secpbench
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2247
Build 2636: Bitcoin ABC Buildbot (legacy)
Build 2635: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 6 2018, 22:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 6 2018, 22:54
deadalnix updated this revision to Diff 3404.Apr 6 2018, 22:55

Add relevent files to .gitignore

teamcity added a subscriber: teamcity.Apr 6 2018, 22:58

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 6 2018, 22:58

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 6 2018, 23:18

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Apr 6 2018, 23:19

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2247: Diff 3403.Apr 6 2018, 23:24
Harbormaster completed remote builds in B2248: Diff 3404.
deadalnix added a child revision: D1251: Build secp256k1 benchmark using cmake.Apr 6 2018, 23:44
deadalnix added a child revision: D1255: [secp256k1] Reduce usage of hardcoded size constant.Apr 8 2018, 13:49
jasonbcox accepted this revision.Apr 8 2018, 14:42
This revision is now accepted and ready to land.Apr 8 2018, 14:42
Closed by commit rABC4642a5e9b468: Enable benchmark building by default and fix benchmarks for gcc 6+ (authored by deadalnix). · Explain WhyApr 8 2018, 14:49
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
secp256k1/
5 lines
src/
8 lines
8 lines
2 lines

Diff 3403

View Options

src/secp256k1/configure.ac

Loading...
View Options

src/secp256k1/src/bench_ecdh.c

Loading...
View Options

src/secp256k1/src/bench_recover.c

Loading...
View Options

src/secp256k1/src/gen_context.c

Loading...