Differential D12520

[Cashtab][Move msg switch p1] Move multi recipients switch out of the Advanvced Collapse on Send Screen
ClosedPublic
Actions

Authored by kieran709 on Nov 16 2022, 19:25.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCf00dba6af1d9: [Cashtab][Move msg switch p1] Move multi recipients switch out of the Advanvced…

Summary

Related to T2772. Moved multi-recipients switch out of the Advanced collapse.

Test Plan

cd web/cashtab && npm start
navigate to send screen
observe that the multiple recipients switch sits above the Address form input
use the switch
observe that the switch's functionality is otherwise unchanged

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kieran709 created this revision.Nov 16 2022, 19:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2022, 19:25

kieran709 requested review of this revision.Nov 16 2022, 19:25

Harbormaster completed remote builds in B20963: Diff 36359.Nov 16 2022, 19:27

Still some content jumping when you hit the switch. I'm seeing the "Send" button and "Advanced" collapse hop up when the switch is turned on, then hop down when it's turned off.
Now that "Advanced" collapse only includes messaging options, it should be retitled "Message", + an envelope or some other appropriate icon. this should be in part 2 of a stacked diff

This revision now requires changes to proceed.Nov 17 2022, 05:29

kieran709 retitled this revision from [Cashtab] Move multi recipients switch out of the Advanvced Collapse on Send Screen to [Cashtab][Pt1] Move multi recipients switch out of the Advanvced Collapse on Send Screen.Nov 17 2022, 17:07

Responding to review feedback, content jumping has been addressed. Instead of conditionally rendering the single and multi address inputs, they have been placed in a div with a fixed min-height. Oon click the max-height of the single / multi address input is reduced to 0.

Harbormaster completed remote builds in B20971: Diff 36381.Nov 17 2022, 17:30

kieran709 retitled this revision from [Cashtab][Pt1] Move multi recipients switch out of the Advanvced Collapse on Send Screen to [Cashtab][Move msg switch p1] Move multi recipients switch out of the Advanvced Collapse on Send Screen.Nov 17 2022, 19:45

kieran709 added a child revision: D12525: [Cashtab][Move msg switch p2] Advanced collapse in Send.js re-titled to Message.Nov 17 2022, 20:16

bytesofman accepted this revision.Nov 19 2022, 15:27

This revision is now accepted and ready to land.Nov 19 2022, 15:27

Closed by commit rABCf00dba6af1d9: [Cashtab][Move msg switch p1] Move multi recipients switch out of the Advanvced… (authored by kieran709). · Explain WhyNov 21 2022, 19:02

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABCf00dba6af1d9: [Cashtab][Move msg switch p1] Move multi recipients switch out of the Advanvced….