Page MenuHomePhabricator
Differential D1252

[cmake] Add support to build native executables
ClosedPublic
Actions

Authored by deadalnix on Apr 7 2018, 20:15.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGa297fd25a27f: [cmake] Add support to build native executables
rABCa297fd25a27f: [cmake] Add support to build native executables
Summary

As per title. This ensures that we can build the executable used to generate various assets.

Test Plan
cmake -GNinja .. -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win32.cmake -DBUILD_BITCOIN_QT=OFF -DBUILD_BITCOIN_SEEDER=OFF
ninja generate_univalue_escapes_h

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmakenativeexec
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2252
Build 2646: Bitcoin ABC Buildbot (legacy)
Build 2645: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 7 2018, 20:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 7 2018, 20:15
teamcity added a subscriber: teamcity.Apr 7 2018, 20:18

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix updated this revision to Diff 3408.Apr 7 2018, 20:32

Exclude native target from all, so behavior is consistent in native and cross builds.

teamcity added a comment.Apr 7 2018, 20:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Apr 7 2018, 20:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix updated this revision to Diff 3409.Apr 7 2018, 20:41

Remove superflusous depends

Harbormaster completed remote builds in B2250: Diff 3407.Apr 7 2018, 20:45
teamcity added a comment.Apr 7 2018, 20:45

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 7 2018, 20:55

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix added a child revision: D1253: [cmake] Add support for ecmult precomputation.Apr 7 2018, 20:58
teamcity added a comment.Apr 7 2018, 21:05

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2251: Diff 3408.Apr 7 2018, 21:05
Harbormaster completed remote builds in B2252: Diff 3409.
deadalnix updated this revision to Diff 3412.Apr 7 2018, 23:54

Refactor the native buolder module to use CMakeCache.txt as an anchor rather than build.ninja and add the phony target native-cmake-build

teamcity added a comment.Apr 7 2018, 23:55

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2255: Diff 3412.Apr 8 2018, 00:15
teamcity added a comment.Apr 8 2018, 00:15

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

schancel accepted this revision.Apr 8 2018, 14:43
schancel edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Apr 8 2018, 14:43
Closed by commit rABCa297fd25a27f: [cmake] Add support to build native executables (authored by deadalnix). · Explain WhyApr 8 2018, 14:54
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
cmake/
modules/
46 lines
src/
univalue/
17 lines

Diff 3409

View Options

cmake/modules/NativeExecutable.cmake

Loading...
View Options

src/univalue/CMakeLists.txt

Loading...