Page MenuHomePhabricator
Differential D12533

test: Properly set sync_fun in NodeNetworkLimitedTest
ClosedPublic
Actions

Authored by Fabien on Nov 18 2022, 14:49.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCfa7b9be30050: test: Properly set sync_fun in NodeNetworkLimitedTest
Summary

This is a partial backport of core#23474:
https://github.com/bitcoin/bitcoin/pull/23474/commits/fad13991aea6463ecf07dd907de1c1b23837d7e7

Test Plan
./test/functional/test_runner.py p2p_node_network_limited

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 18 2022, 14:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 18 2022, 14:49
Fabien requested review of this revision.Nov 18 2022, 14:49
teamcity edited the summary of this revision. (Show Details)Nov 18 2022, 14:49
Harbormaster completed remote builds in B20983: Diff 36394.Nov 18 2022, 15:08
Fabien added a child revision: D12535: scripted-diff: Remove redundant sync_all and sync_blocks.Nov 18 2022, 16:53
PiRK accepted this revision.Nov 18 2022, 17:01
PiRK added a subscriber: PiRK.
PiRK added inline comments.
test/functional/p2p_node_network_limited.py
75 ↗(On Diff #36394)

Could be shortened with slicing indexes, but I also see the value of sticking with the source material.

This revision is now accepted and ready to land.Nov 18 2022, 17:01
Closed by commit rABCfa7b9be30050: test: Properly set sync_fun in NodeNetworkLimitedTest (authored by Fabien). · Explain WhyNov 18 2022, 20:37
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCfa7b9be30050: test: Properly set sync_fun in NodeNetworkLimitedTest.

Revision Contents
Changeset List

PathSize
test/
functional/
4 lines

Diff 36405

View Options

test/functional/p2p_node_network_limited.py

Loading...