Page MenuHomePhabricator
Differential D1253

[cmake] Add support for ecmult precomputation
ClosedPublic
Actions

Authored by deadalnix on Apr 7 2018, 20:57.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING4fd7d42c219e: [cmake] Add support for ecmult precomputation
rABC4fd7d42c219e: [cmake] Add support for ecmult precomputation
Summary

As per title.

Test Plan
ninja

On both a native build and a wind32 build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secp256k1emlt
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2259
Build 2660: Bitcoin ABC Buildbot (legacy)
Build 2659: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 7 2018, 20:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 7 2018, 20:57
deadalnix added a parent revision: D1252: [cmake] Add support to build native executables.Apr 7 2018, 20:58
deadalnix updated this revision to Diff 3411.Apr 7 2018, 20:59

Remove outdated todos

teamcity added a subscriber: teamcity.Apr 7 2018, 21:06

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 7 2018, 21:06

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 7 2018, 21:24

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Apr 7 2018, 21:25

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2254: Diff 3411.Apr 7 2018, 21:26
Harbormaster completed remote builds in B2253: Diff 3410.
schancel requested changes to this revision.Apr 8 2018, 14:44
schancel added a subscriber: schancel.
schancel added inline comments.
src/secp256k1/CMakeLists.txt
84 ↗(On Diff #3411)

mutliplicationt ables -> multiplication tables

This revision now requires changes to proceed.Apr 8 2018, 14:44
deadalnix updated this revision to Diff 3423.Apr 8 2018, 14:57

Fix typos

schancel accepted this revision.Apr 8 2018, 15:02
This revision is now accepted and ready to land.Apr 8 2018, 15:02
Closed by commit rABC4fd7d42c219e: [cmake] Add support for ecmult precomputation (authored by deadalnix). · Explain WhyApr 8 2018, 15:11
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Apr 8 2018, 17:48

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 8 2018, 18:08

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2259: Diff 3423.Apr 8 2018, 18:09

Revision Contents
Changeset List

PathSize
src/
secp256k1/
18 lines
src/
2 lines

Diff 3423

View Options

src/secp256k1/CMakeLists.txt

Loading...
View Options

src/secp256k1/src/libsecp256k1-config.h.cmake.in

Loading...