[Cashtab] Parse edge case eToken tx
ClosedPublic
Actions

Authored by bytesofman on Nov 21 2022, 11:40.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCe02ddf690a93: [Cashtab] Parse edge case eToken tx

Summary

T2795

A new eToken swap wallet creates a type of tx previously ignored in Cashtab tx parsing. This diff parses it as an incoming XEC tx.

A task has been created to improve this parsing by flagging it as an eToken tx with an XEC output. In the future, we may be able to tag these txs as being from a specific app.

Test Plan

Ping me on telegram for the seed to a wallet with this kind of tx
npm start and verify correct parsing

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 21 2022, 11:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2022, 11:40

bytesofman requested review of this revision.Nov 21 2022, 11:40

Harbormaster completed remote builds in B21009: Diff 36427.Nov 21 2022, 11:46

Adding unit test

Harbormaster completed remote builds in B21010: Diff 36428.Nov 21 2022, 11:53

emack accepted this revision.Nov 22 2022, 07:21

emack added a subscriber: emack.

emack added inline comments.

web/cashtab/src/utils/chronik.js
710 ↗	(On Diff #36428)	is it worth just using 'Swap Tx' as the OP_RETURN message?

This revision is now accepted and ready to land.Nov 22 2022, 07:21

bytesofman requested review of this revision.Nov 22 2022, 08:10

bytesofman added inline comments.

web/cashtab/src/utils/chronik.js
710 ↗	(On Diff #36428)	I considered this but instead created this task to handle T2796 The msg approach "works" but it is kind of confusing to display this as a message. Have the weird hurdle of "not in your contact list." I think the right way to do it is to add more info to the parsed tx, so that Cashtab can render these in a unique way.