scripted-diff: Remove redundant sync_all and sync_blocks
ec049aa03927
Actions

Description

scripted-diff: Remove redundant sync_all and sync_blocks

Summary:

The sync calls are redundant after a call to generate, because generate
already syncs itself.

Completes backport of core#23474:
https://github.com/bitcoin/bitcoin/pull/23474/commits/fa974f1f1417a536636347072e86bcb54a4c909c

Depends on D12533.

Test Plan:

ninja check-functional-extended

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D12535

Details

Provenance

MarcoFalke <falke.marco@gmail.com>	Authored on Jul 28 2021, 10:12
Fabien	Committed on Nov 18 2022, 20:37
Fabien	Pushed on Nov 18 2022, 20:37

Reviewer

Restricted Project

Differential Revision

D12535: scripted-diff: Remove redundant sync_all and sync_blocks

Parents

rABCfa7b9be30050: test: Properly set sync_fun in NodeNetworkLimitedTest

Branches

Unknown

Tags

Unknown

Event Timeline

Fabien committed rABCec049aa03927: scripted-diff: Remove redundant sync_all and sync_blocks (authored by MarcoFalke <falke.marco@gmail.com>).Nov 18 2022, 20:37

Fabien added an edge: D12535: scripted-diff: Remove redundant sync_all and sync_blocks.

Changes (36)

Path

Size

test/

functional/

abc-parkedchain.py

abc_p2p_avalanche_peer_discovery.py

feature_coinstatsindex.py

interface_rest.py

interface_zmq.py

mempool_packages.py

mining_getblocktemplate_longpoll.py

rpc_createmultisig.py

rpc_fundrawtransaction.py

rpc_getblockstats.py

rpc_psbt.py

rpc_rawtransaction.py

rpc_txoutproof.py

wallet_abandonconflict.py

wallet_address_types.py

wallet_import_rescan.py

wallet_importdescriptors.py

wallet_importprunedfunds.py

wallet_keypool_topup.py

wallet_listreceivedby.py

wallet_listsinceblock.py

wallet_listtransactions.py

wallet_reorgsrestore.py

wallet_send.py

wallet_txn_clone.py

wallet_txn_doublespend.py

rABCec049aa03927

View Options

test/functional/abc-parkedchain.py

View Options

test/functional/abc_p2p_avalanche_peer_discovery.py

View Options

test/functional/feature_coinstatsindex.py

View Options

test/functional/interface_rest.py

View Options

test/functional/interface_zmq.py

View Options

test/functional/mempool_packages.py

View Options

test/functional/mining_getblocktemplate_longpoll.py

View Options

test/functional/p2p_blockfilters.py

View Options

test/functional/p2p_ibd_txrelay.py

View Options

test/functional/p2p_permissions.py

View Options

test/functional/p2p_sendheaders.py

View Options

test/functional/rpc_createmultisig.py

View Options

test/functional/rpc_fundrawtransaction.py

View Options

test/functional/rpc_getblockstats.py

View Options

test/functional/rpc_psbt.py

View Options

test/functional/rpc_rawtransaction.py

View Options

test/functional/rpc_txoutproof.py

View Options

test/functional/wallet_abandonconflict.py

View Options

test/functional/wallet_address_types.py

View Options

test/functional/wallet_avoidreuse.py

View Options

test/functional/wallet_backup.py

View Options

test/functional/wallet_balance.py

View Options

test/functional/wallet_basic.py

View Options

test/functional/wallet_groups.py

View Options

test/functional/wallet_hd.py

View Options

test/functional/wallet_import_rescan.py

View Options

test/functional/wallet_importdescriptors.py

View Options

test/functional/wallet_importprunedfunds.py

View Options

test/functional/wallet_keypool_topup.py

View Options

test/functional/wallet_listreceivedby.py

View Options

test/functional/wallet_listsinceblock.py

View Options

test/functional/wallet_listtransactions.py

View Options

test/functional/wallet_reorgsrestore.py

View Options

test/functional/wallet_send.py

View Options

test/functional/wallet_txn_clone.py

View Options

test/functional/wallet_txn_doublespend.py

scripted-diff: Remove redundant sync_all and sync_blocksec049aa03927Actions

Description

Details

Event Timeline

Changes (36)

rABCec049aa03927

test/functional/abc-parkedchain.py

test/functional/abc_p2p_avalanche_peer_discovery.py

test/functional/feature_coinstatsindex.py

test/functional/interface_rest.py

test/functional/interface_zmq.py

test/functional/mempool_packages.py

test/functional/mining_getblocktemplate_longpoll.py

test/functional/p2p_blockfilters.py

test/functional/p2p_ibd_txrelay.py

test/functional/p2p_permissions.py

test/functional/p2p_sendheaders.py

test/functional/rpc_createmultisig.py

test/functional/rpc_fundrawtransaction.py

test/functional/rpc_getblockstats.py

test/functional/rpc_psbt.py

test/functional/rpc_rawtransaction.py

test/functional/rpc_txoutproof.py

test/functional/wallet_abandonconflict.py

test/functional/wallet_address_types.py

test/functional/wallet_avoidreuse.py

test/functional/wallet_backup.py

test/functional/wallet_balance.py

test/functional/wallet_basic.py

test/functional/wallet_groups.py

test/functional/wallet_hd.py

test/functional/wallet_import_rescan.py

test/functional/wallet_importdescriptors.py

test/functional/wallet_importprunedfunds.py

test/functional/wallet_keypool_topup.py

test/functional/wallet_listreceivedby.py

test/functional/wallet_listsinceblock.py

test/functional/wallet_listtransactions.py

test/functional/wallet_reorgsrestore.py

test/functional/wallet_send.py

test/functional/wallet_txn_clone.py

test/functional/wallet_txn_doublespend.py

scripted-diff: Remove redundant sync_all and sync_blocks
ec049aa03927
Actions