Page MenuHomePhabricator
Differential D12561

Move common logging AddArg code to init/common
ClosedPublic
Actions

Authored by PiRK on Nov 21 2022, 15:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5dc1cff24adb: Move common logging AddArg code to init/common
Summary

This is a partial backport of core#21732 and core#21060
https://github.com/bitcoin/bitcoin/pull/21732/commits/90469c16906ab451bb1250df5e51563870a7ef3b

Depends on D12560

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 21 2022, 15:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2022, 15:53
PiRK requested review of this revision.Nov 21 2022, 15:53
teamcity edited the summary of this revision. (Show Details)Nov 21 2022, 15:53
PiRK added a child revision: D12562: Move common logging GetArgs code to init/common.Nov 21 2022, 15:55
Harbormaster completed remote builds in B21025: Diff 36443.Nov 21 2022, 16:14
Fabien accepted this revision.Nov 21 2022, 17:23
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/init.cpp
38 ↗(On Diff #36443)

Seems unrelated

This revision is now accepted and ready to land.Nov 21 2022, 17:23
PiRK updated this revision to Diff 36459.Nov 21 2022, 19:03

put back #include <miner.h> (most likely removed by accident)

Harbormaster completed remote builds in B21033: Diff 36459.Nov 21 2022, 19:20
Closed by commit rABC5dc1cff24adb: Move common logging AddArg code to init/common (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhyNov 22 2022, 12:21
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5dc1cff24adb: Move common logging AddArg code to init/common.

Revision Contents
Changeset List

PathSize
src/
74 lines
init/
3 lines
81 lines

Diff 36487

View Options

src/init.cpp

Loading...
View Options

src/init/common.h

Loading...
View Options

src/init/common.cpp

Loading...