[Cashtab] [BCH deprecation] [TxBuilder] Pt 3/8 - Add local TxBuilder to createToken
ClosedPublic
Actions

Authored by emack on Nov 22 2022, 12:58.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC2ca71af04e4c: [Cashtab] [BCH deprecation] [TxBuilder] Pt 3/8 - Add local TxBuilder to…

Summary

T2730

Depends on D12553

This diff updates the createToken() function to use the local transaction builder module and compares the txBuilder object after adding input, output and signing/building tx.

Pt 1/8 - Localize Transaction Builder module
Pt 2/8 - Deprecate BCH.TransactionBuilder in sendXec
Pt 3/8 - Add local TxBuilder to createToken
Pt 4/8 - Deprecate BCH.TransactionBuilder in createToken
Pt 5/8 - Add local TxBuilder to sendToken
Pt 6/8 - Deprecate BCH.TransactionBuilder in sendToken
Pt 7/8 - Add local TxBuilder to burnToken
Pt 8/8 - Deprecate BCH.TransactionBuilder in burnToken

Test Plan

npm ci
npm test and ensure no errors with txBuilder.test.js
npm start
create a new token and ensure the following 3 console log messages are displayed:
post-generateTokenTxInput() output matches
post-generateTokenTxOutput() output matches
post-signAndBuildTx() output matches

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Nov 22 2022, 12:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2022, 12:58

emack requested review of this revision.Nov 22 2022, 12:58

Harbormaster completed remote builds in B21047: Diff 36491.Nov 22 2022, 13:01

emack added a child revision: D12575: [Cashtab] [BCH deprecation] [TxBuilder] Pt 4/8 - Deprecate BCH.TransactionBuilder in createToken.Nov 22 2022, 13:54

looks good but dependencies need to be rebased, I get this error when I arc patch

COMMITTED  Successfully committed patch.

 Cherry Pick Failed!
 Exception 
Command failed with error #1!
COMMAND
git cherry-pick -- arcpatch-D12541_1

STDOUT
Auto-merging web/cashtab/package-lock.json
CONFLICT (content): Merge conflict in web/cashtab/package-lock.json
Auto-merging web/cashtab/package.json
CONFLICT (content): Merge conflict in web/cashtab/package.json


STDERR
error: could not apply cbd56641c... [Cashtab] [BCH deprecation] [TxBuilder] Pt 1/8 - Localize Transaction Building module

This revision now requires changes to proceed.Nov 23 2022, 08:28

rebase

Harbormaster completed remote builds in B21070: Diff 36543.Nov 23 2022, 09:49

bytesofman accepted this revision.Nov 23 2022, 10:49

This revision is now accepted and ready to land.Nov 23 2022, 10:49

Closed by commit rABC2ca71af04e4c: [Cashtab] [BCH deprecation] [TxBuilder] Pt 3/8 - Add local TxBuilder to… (authored by emack). · Explain WhyNov 25 2022, 11:23

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC2ca71af04e4c: [Cashtab] [BCH deprecation] [TxBuilder] Pt 3/8 - Add local TxBuilder to….