Differential D12578

node/chainstate: Decouple from ShutdownRequested
ClosedPublic
Actions

Authored by Fabien on Nov 22 2022, 16:00.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC8d9a8aa4ce6c: node/chainstate: Decouple from ShutdownRequested

Summary

...instead allow optionally passing in a std::function<bool()>

Partial backport of core#23280:
https://github.com/bitcoin/bitcoin/pull/23280/commits/4da9c076d1cf12728730bb1f7e8906d4e9bfaba5

Depends on D12577.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 22 2022, 16:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2022, 16:00

Fabien requested review of this revision.Nov 22 2022, 16:00

teamcity edited the summary of this revision. (Show Details)Nov 22 2022, 16:00

Fabien added a child revision: D12579: validation: LoadChainstate only needs Consensus::Params.Nov 22 2022, 16:01

Harbormaster completed remote builds in B21051: Diff 36504.Nov 22 2022, 16:26

sdulfari accepted this revision.Nov 22 2022, 17:09

This revision is now accepted and ready to land.Nov 22 2022, 17:09

Closed by commit rABC8d9a8aa4ce6c: node/chainstate: Decouple from ShutdownRequested (authored by Carl Dong <contact@carldong.me>, committed by Fabien). · Explain WhyNov 22 2022, 19:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC8d9a8aa4ce6c: node/chainstate: Decouple from ShutdownRequested.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

2 lines

node/

chainstate.h

5 lines

chainstate.cpp

9 lines

Diff 36515

View Options

src/init.cpp

View Options

src/node/chainstate.h

View Options

node/chainstate: Decouple from ShutdownRequestedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36515

src/init.cpp

src/node/chainstate.h

src/node/chainstate.cpp

node/chainstate: Decouple from ShutdownRequested
ClosedPublic
Actions

Revision Contents
Changeset List