Differential D12583

test/setup: Use LoadChainstate
ClosedPublic
Actions

Authored by Fabien on Nov 22 2022, 16:02.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC275c7dfdd205: test/setup: Use LoadChainstate

Summary

This commit coalesces the chainstate loading sequence between our unit test and non-unit test init codepaths.

Partial backport of core#23280:
https://github.com/bitcoin/bitcoin/pull/23280/commits/9a5a5a3d08b2c130ab9147914739ff3583b0dc84

Depends on D12582.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 22 2022, 16:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2022, 16:02

Fabien requested review of this revision.Nov 22 2022, 16:02

teamcity edited the summary of this revision. (Show Details)Nov 22 2022, 16:02

Fabien added a child revision: D12584: Remove all #include // for * comments.Nov 22 2022, 16:03

Harbormaster completed remote builds in B21056: Diff 36509.Nov 22 2022, 16:44

PiRK accepted this revision.Nov 22 2022, 17:22

This revision is now accepted and ready to land.Nov 22 2022, 17:22

Closed by commit rABC275c7dfdd205: test/setup: Use LoadChainstate (authored by Carl Dong <contact@carldong.me>, committed by Fabien). · Explain WhyNov 22 2022, 19:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC275c7dfdd205: test/setup: Use LoadChainstate.

Revision Contents
Changeset List

Path

Size

src/

test/

util/

setup_common.h

3 lines

setup_common.cpp

36 lines

Diff 36520

View Options

src/test/util/setup_common.h