Page MenuHomePhabricator

[Cashtab] [Simplify wallet structure p2] Remove duplicate tokens array
ClosedPublic

Authored by bytesofman on Nov 23 2022, 08:58.

Details

Summary

T2663

Depends on D12590

Remove repeated tokens object. This is used nowhere in the app and can simply be removed.

Test Plan

npm start
Wait for update to run at least once and to see dev log msg confirming updated wallet has been saved to storage
Change wallets
Wait for update to run at least once and to see dev log msg confirming updated wallet has been saved to storage
Change back
Review local storage. Click 'update' to refresh local storage display. Confirm that the wallet you used is saved without the duplicate tokens array under savedWallets

grep -r slpBalancesAndUtxos.tokens src/ has no output
Review grep -r slpBalancesAndUtxos to confirm these references are not using the slpBalancesAndUtxos.tokens array

Diff Detail

Repository
rABC Bitcoin ABC
Branch
streamline-wallet-structure
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21065
Build 41784: Build Diffcashtab-tests
Build 41783: arc lint + arc unit

Event Timeline

emack requested changes to this revision.Nov 24 2022, 01:02
emack added a subscriber: emack.

I'm still seeing the tokens array inside slpBalancesAndUtxos object

image.png (589×487 px, 70 KB)

Also double checking, is this now the Update indicator in the console log?

image.png (123×372 px, 25 KB)

This revision now requires changes to proceed.Nov 24 2022, 01:02
This revision is now accepted and ready to land.Nov 25 2022, 11:00