Page MenuHomePhabricator
Differential D12593

[Cashtab] [Simplify wallet structure p3] Remove unused utxos array
ClosedPublic
Actions

Authored by bytesofman on Nov 23 2022, 09:11.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCac51cf4ec09f: [Cashtab] [Simplify wallet structure p3] Remove unused utxos array
Summary

T2663

Depends on D12592

Remove the unused utxos array from wallet state.

Because isValidStoredWallet must recognize the wallets from before this stack and after this stack as valid, adjust unit tests and mocks accordingly.

Test Plan

Review unit test adjustments and npm test
npm start
Wait for update to run
Change wallets
Wait for update to run
Observe local storage and see that wallet state is updated for wallet and the previously active wallet in savedWallets

Diff Detail

Repository
rABC Bitcoin ABC
Branch
streamline-wallet-structure
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21132
Build 41916: Build Diffcashtab-tests
Build 41915: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 23 2022, 09:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2022, 09:11
bytesofman requested review of this revision.Nov 23 2022, 09:11
Harbormaster completed remote builds in B21067: Diff 36540.Nov 23 2022, 09:26
bytesofman updated this revision to Diff 36610.Nov 25 2022, 10:21

Added additional logging to confirm when wallet update is completed

Harbormaster completed remote builds in B21128: Diff 36610.Nov 25 2022, 10:30
bytesofman updated this revision to Diff 36613.Nov 25 2022, 10:31

rebase

bytesofman updated this revision to Diff 36614.Nov 25 2022, 10:35

Remove unrelated line break change

Harbormaster completed remote builds in B21132: Diff 36614.Nov 25 2022, 10:38
Harbormaster completed remote builds in B21131: Diff 36613.Nov 25 2022, 10:41
emack accepted this revision.Nov 25 2022, 10:45
This revision is now accepted and ready to land.Nov 25 2022, 10:45
bytesofman added a child revision: D12625: [Cashtab] [Simplify wallet structure p4] Remove parent artifact object slpBalancesAndUtxos.Nov 25 2022, 12:32
bytesofman updated this revision to Diff 36688.Nov 26 2022, 07:41

rebase

Harbormaster completed remote builds in B21176: Diff 36688.Nov 26 2022, 07:47
bytesofman updated this revision to Diff 36724.Nov 28 2022, 04:50

rebase

Harbormaster completed remote builds in B21198: Diff 36724.Nov 28 2022, 05:07
bytesofman updated this revision to Diff 36804.Nov 30 2022, 08:16

rebase

Harbormaster completed remote builds in B21254: Diff 36804.Nov 30 2022, 08:40
Closed by commit rABCac51cf4ec09f: [Cashtab] [Simplify wallet structure p3] Remove unused utxos array (authored by bytesofman). · Explain WhyDec 1 2022, 07:57
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCac51cf4ec09f: [Cashtab] [Simplify wallet structure p3] Remove unused utxos array.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
1 line
utils/
__mocks__/
450 lines
__tests__/
8 lines
1 line

Diff 36614

View Options

web/cashtab/src/hooks/useWallet.js

Loading...
View Options

web/cashtab/src/utils/__mocks__/mockStoredWallets.js

Loading...
View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...