Paths

Table of Contentst

Differential D12618

[Cashtab] [ECPair from wif p2/3] Deprecate BCH method
ClosedPublic
Actions

Authored by bytesofman on Nov 25 2022, 09:56.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC1bbfda74738f: [Cashtab] [ECPair from wif p2/3] Deprecate BCH method

Summary

T2730

Depends on D12616

Remove BCH param from function and migrate to new local method

Test Plan

npm test and confirm existing unit tests of function that depends on this param still work
npm start, send some transactions, confirm they work

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21138
Build 41928: Build Diff	cashtab-tests
Build 41927: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 25 2022, 09:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2022, 09:56

bytesofman requested review of this revision.Nov 25 2022, 09:56

bytesofman mentioned this in D12489: [Cashtab] [ECPair from wif p2] Deprecate BCH method.Nov 25 2022, 09:57

Harbormaster completed remote builds in B21124: Diff 36606.Nov 25 2022, 09:59

bytesofman added a child revision: D12619: [Cashtab] [ECPair from wif p3/3] Consistent camel case for ECPair.Nov 25 2022, 10:00

emack accepted this revision.Nov 25 2022, 10:28

This revision is now accepted and ready to land.Nov 25 2022, 10:28

rebase

Harbormaster completed remote builds in B21138: Diff 36628.Nov 25 2022, 12:41

Closed by commit rABC1bbfda74738f: [Cashtab] [ECPair from wif p2/3] Deprecate BCH method (authored by bytesofman). · Explain WhyNov 25 2022, 12:44

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC1bbfda74738f: [Cashtab] [ECPair from wif p2/3] Deprecate BCH method.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

utils/

__tests__/

cashMethods.test.js

2 lines

cashMethods.js

19 lines

Diff 36628

View Options

web/cashtab/src/utils/tests/cashMethods.test.js

View Options

web/cashtab/src/utils/cashMethods.js

[Cashtab] [ECPair from wif p2/3] Deprecate BCH methodClosedPublicActions