Page MenuHomePhabricator
Differential D12651

[Cashtab] [Address simplification p1/4] Stopconverting to BCH formats for Send Token
ClosedPublic
Actions

Authored by bytesofman on Nov 27 2022, 13:29.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC92728a0d76d1: [Cashtab] [Address simplification p1/4] Stopconverting to BCH formats for Send…
Summary

T2730

Part 1 of a stacked diff to remove unnecessary address conversions

In this diff, we stop converting destination token addresses to simpleledger: format, and stop converting the output address to legacy format.

Both of these steps are artifacts relating to previous use of bch-js, which required these formats in creating transactions.

Test Plan

npm start
Send an etoken tx to an etoken address

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 27 2022, 13:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2022, 13:29
bytesofman requested review of this revision.Nov 27 2022, 13:29
Harbormaster completed remote builds in B21181: Diff 36700.Nov 27 2022, 13:32
bytesofman added a child revision: D12652: [Cashtab] [Address simplification p2/4] Stop converting to legacy format for Burn Token.Nov 27 2022, 13:35
bytesofman retitled this revision from [Cashtab] [Address simplification p1] Stopconverting to BCH formats for Send Token to [Cashtab] [Address simplification p1/4] Stopconverting to BCH formats for Send Token.Nov 27 2022, 13:46
emack accepted this revision.Nov 28 2022, 01:22
This revision is now accepted and ready to land.Nov 28 2022, 01:22
Closed by commit rABC92728a0d76d1: [Cashtab] [Address simplification p1/4] Stopconverting to BCH formats for Send… (authored by bytesofman). · Explain WhyNov 28 2022, 04:27
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC92728a0d76d1: [Cashtab] [Address simplification p1/4] Stopconverting to BCH formats for Send….

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Send/
5 lines
utils/
4 lines

Diff 36712

View Options

web/cashtab/src/components/Send/SendToken.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...