[Cashtab] [Address simplification p2/4] Stop converting to legacy format for Burn Token
ClosedPublic
Actions

Authored by bytesofman on Nov 27 2022, 13:35.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCb023c6df92fc: [Cashtab] [Address simplification p2/4] Stop converting to legacy format for…

Summary

T2730

Depends on D12651

Stop converting burn outputs to legacy address format. Transaction builder will work with existing format (which is cashAddress, to be corrected to ecash: format in a future diff)

Test Plan

npm start
Do a token burn tx
Sanity check it on block explorer

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 27 2022, 13:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2022, 13:35

bytesofman requested review of this revision.Nov 27 2022, 13:35

Harbormaster completed remote builds in B21182: Diff 36701.Nov 27 2022, 13:38

bytesofman added a child revision: D12653: [Cashtab] [Address simplification p3/4] Deprecate BCH param from generateTokenTxOutput.Nov 27 2022, 13:39

bytesofman retitled this revision from [Cashtab] [Address simplification p2] Stop converting to legacy format for Burn Token to [Cashtab] [Address simplification p2/4] Stop converting to legacy format for Burn Token.Nov 27 2022, 13:46

emack accepted this revision.Nov 28 2022, 01:47

This revision is now accepted and ready to land.Nov 28 2022, 01:47

Closed by commit rABCb023c6df92fc: [Cashtab] [Address simplification p2/4] Stop converting to legacy format for… (authored by bytesofman). · Explain WhyNov 28 2022, 04:27

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCb023c6df92fc: [Cashtab] [Address simplification p2/4] Stop converting to legacy format for….