Page MenuHomePhabricator
Differential D12653

[Cashtab] [Address simplification p3/4] Deprecate BCH param from generateTokenTxOutput
ClosedPublic
Actions

Authored by bytesofman on Nov 27 2022, 13:39.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC6cf21327f23c: [Cashtab] [Address simplification p3/4] Deprecate BCH param from…
Summary

T2730

Depends on D12652

Remove now-unused BCH param from generateTokenTxOutput function and function calls

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
simplify-address-formats-stack
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21183
Build 42018: Build Diffcashtab-tests
Build 42017: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 27 2022, 13:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2022, 13:39
bytesofman requested review of this revision.Nov 27 2022, 13:39
bytesofman added a child revision: D12654: [Cashtab] [Address simplification p4/4] Remove unused toLegacyToken function.Nov 27 2022, 13:41
Harbormaster completed remote builds in B21183: Diff 36702.Nov 27 2022, 13:41
bytesofman retitled this revision from [Cashtab] [Address simplification p3] Deprecate BCH param from generateTokenTxOutput to [Cashtab] [Address simplification p3/4] Deprecate BCH param from generateTokenTxOutput.Nov 27 2022, 13:46
emack accepted this revision.Nov 28 2022, 01:58
This revision is now accepted and ready to land.Nov 28 2022, 01:58
Closed by commit rABC6cf21327f23c: [Cashtab] [Address simplification p3/4] Deprecate BCH param from… (authored by bytesofman). · Explain WhyNov 28 2022, 04:27
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC6cf21327f23c: [Cashtab] [Address simplification p3/4] Deprecate BCH param from….

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
3 lines
utils/
__tests__/
6 lines
3 lines

Diff 36702

View Options

web/cashtab/src/hooks/useBCH.js

Loading...
View Options

web/cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

web/cashtab/src/utils/cashMethods.js

Loading...