Details

Reviewers

kieran709

Group Reviewers

Restricted Project

Commits

rABC315b69ee6a34: [Cashtab] [Simplify wallet structure p8] Remove debug logging

Summary

T2663

Depends on D12661

Remove debug logging to complete wallet structure streamline

Test Plan

npm start
Inspect indexedDb to confirm active wallet matches desired pattern
Switch wallets a lot. Active wallet should always match desired pattern on load. SavedWallet should match desired pattern after active wallet is switched off again.
Try to break it by switching wallets a lot.
Confirm indexedDb wallets match desired pattern

Diff Detail

Repository

rABC Bitcoin ABC

Branch

streamline-wallet-structure

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21260
Build 42172: Build Diff	cashtab-tests
Build 42171: arc lint + arc unit

Event Timeline

bytesofman created this revision.Nov 28 2022, 05:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2022, 05:21

bytesofman requested review of this revision.Nov 28 2022, 05:21

Harbormaster completed remote builds in B21203: Diff 36729.Nov 28 2022, 05:24

kieran709 accepted this revision.Nov 29 2022, 16:05

This revision is now accepted and ready to land.Nov 29 2022, 16:05

rebase

Harbormaster completed remote builds in B21259: Diff 36809.Nov 30 2022, 08:43

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: useBCH hook Throws error attempting to burn an eToken ID that is not within the wallet's utxo ======
Error: expect(received).toStrictEqual(expected) // deep equality

Expected: [Error: No token UTXOs for the specified token could be found.]
Received: [TypeError: Cannot destructure property 'tokenId' of 'undefined' as it is undefined.]
    at Object.<anonymous> (/work/web/cashtab/src/hooks/__tests__/useBCH.test.js:211:29)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: useBCH hook Throws error attempting to burn an eToken ID that is not within the wallet's utxo

Harbormaster completed remote builds in B21260: Diff 36810.Nov 30 2022, 08:45

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: useBCH hook Throws error attempting to burn an eToken ID that is not within the wallet's utxo ======
Error: expect(received).toStrictEqual(expected) // deep equality

Expected: [Error: No token UTXOs for the specified token could be found.]
Received: [TypeError: Cannot destructure property 'tokenId' of 'undefined' as it is undefined.]
    at Object.<anonymous> (/work/web/cashtab/src/hooks/__tests__/useBCH.test.js:211:29)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: useBCH hook Throws error attempting to burn an eToken ID that is not within the wallet's utxo