Page MenuHomePhabricator

[Cashtab] Deprecate BCH from getMintAddress
ClosedPublic

Authored by bytesofman on Nov 28 2022, 07:30.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC925a747bb883: [Cashtab] Deprecate BCH from getMintAddress
Summary

T2730

Depends on D12669

Deprecate the BCH param from the getMintAddress function

As this means BCH is no longer used in Airdrop.js, requires deprecating from there as well in this diff.

Test Plan

npm test
npm start
Calculate an airdrop tx with minting address ignored

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Tail of the build log:

npm WARN EBADENGINE   package: 'postcss-place@7.0.5',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-preset-env@7.8.2',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-pseudo-class-any-link@7.1.6',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'postcss-selector-not@6.0.1',
npm WARN EBADENGINE   required: { node: '^12 || ^14 || >=16' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }

> cashtab@1.0.0 prepare
> cd ../.. && husky install web/cashtab/.husky

husky - Git hooks installed

added 1813 packages, and audited 1814 packages in 33s

234 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (5 moderate, 2 high, 1 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
npm notice 
npm notice New major version of npm available! 7.7.6 -> 9.1.2
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.2>
npm notice Run `npm install -g npm@9.1.2` to update!
npm notice 

> cashtab@1.0.0 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

[eslint] 
src/utils/chronik.js
  Line 9:5:   'convertEcashtoEtokenAddr' is defined but never used  no-unused-vars
  Line 10:5:  'convertToEcashPrefix' is defined but never used      no-unused-vars

Search for the keywords to learn more about each error.


Build cashtab-tests failed with exit code 1
This revision is now accepted and ready to land.Nov 29 2022, 14:44