Paths

Table of Contentst

Differential D12679

[Cashtab] [deprecate etoken addresses p2] Remove type-specific address descriptors from placeholders and error msgs
ClosedPublic
Actions

Authored by bytesofman on Nov 28 2022, 14:25.

Details

Reviewers

kieran709

Group Reviewers

Restricted Project

Commits

rABC9bc95142d3af: [Cashtab] [deprecate etoken addresses p2] Remove type-specific address…

Summary

T2802

Depends on D12677

Remove type-specific address labels and validation errors

Test Plan

npm start
Check placeholders on Send and SendToken screens
Check placeholder on Send XEC one to many screen
Check validation messages

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 28 2022, 14:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2022, 14:25

bytesofman requested review of this revision.Nov 28 2022, 14:25

Harbormaster completed remote builds in B21222: Diff 36748.Nov 28 2022, 14:28

bytesofman mentioned this in D12680: [Cashtab] [deprecate etoken addresses p3] Remove address switch on receive screen.Nov 28 2022, 14:46

bytesofman added a child revision: D12680: [Cashtab] [deprecate etoken addresses p3] Remove address switch on receive screen.Nov 28 2022, 14:56

kieran709 accepted this revision.Nov 28 2022, 23:13

This revision is now accepted and ready to land.Nov 28 2022, 23:13

Closed by commit rABC9bc95142d3af: [Cashtab] [deprecate etoken addresses p2] Remove type-specific address… (authored by bytesofman). · Explain WhyNov 29 2022, 06:28

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC9bc95142d3af: [Cashtab] [deprecate etoken addresses p2] Remove type-specific address….

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Send/

Send.js

6 lines

SendToken.js

4 lines

__tests__/

__snapshots__/

Send.test.js.snap

SendToken.test.js.snap

Diff 36764

View Options

web/cashtab/src/components/Send/Send.js

View Options

web/cashtab/src/components/Send/SendToken.js

View Options

web/cashtab/src/components/Send/tests/snapshots/Send.test.js.snap

View Options

web/cashtab/src/components/Send/tests/snapshots/SendToken.test.js.snap

[Cashtab] [deprecate etoken addresses p2] Remove type-specific address descriptors from placeholders and error msgsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36764

web/cashtab/src/components/Send/Send.js

web/cashtab/src/components/Send/SendToken.js

web/cashtab/src/components/Send/__tests__/__snapshots__/Send.test.js.snap

web/cashtab/src/components/Send/__tests__/__snapshots__/SendToken.test.js.snap

[Cashtab] [deprecate etoken addresses p2] Remove type-specific address descriptors from placeholders and error msgs
ClosedPublic
Actions

Revision Contents
Changeset List

web/cashtab/src/components/Send/tests/snapshots/Send.test.js.snap

web/cashtab/src/components/Send/tests/snapshots/SendToken.test.js.snap