Page MenuHomePhabricator
Differential D12701

rpc: move Ensure* helpers to server_util.h
ClosedPublic
Actions

Authored by PiRK on Nov 30 2022, 15:01.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd4cad3ef2d75: rpc: move Ensure* helpers to server_util.h
Summary

This is a partial backport of core#20295
https://github.com/bitcoin/bitcoin/pull/20295/commits/b884ababc29ce963826d8a4327ed6a5e629ff175

Depends on D12700

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 30 2022, 15:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2022, 15:01
PiRK requested review of this revision.Nov 30 2022, 15:01
teamcity edited the summary of this revision. (Show Details)Nov 30 2022, 15:01
Fabien accepted this revision.Nov 30 2022, 15:32
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/blockchain.cpp
37 ↗(On Diff #36822)

Why is that needed ?

This revision is now accepted and ready to land.Nov 30 2022, 15:32
PiRK added inline comments.Nov 30 2022, 15:36
src/rpc/blockchain.cpp
37 ↗(On Diff #36822)

That's a conflict resolution accident. I will remove it
.

Harbormaster completed remote builds in B21270: Diff 36822.Nov 30 2022, 15:40
Closed by commit rABCd4cad3ef2d75: rpc: move Ensure* helpers to server_util.h (authored by Sjors Provoost <sjors@sprovoost.nl>, committed by PiRK). · Explain WhyNov 30 2022, 16:25
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCd4cad3ef2d75: rpc: move Ensure* helpers to server_util.h.

Revision Contents
Changeset List

PathSize
src/
1 line
1 line
rpc/
1 line
6 lines
33 lines
2 lines
1 line
21 lines
1 line
24 lines
64 lines

Diff 36831

View Options

src/CMakeLists.txt

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/rpc/avalanche.cpp

Loading...
View Options

src/rpc/blockchain.h

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/net.h

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/rpc/server_util.h

Loading...
View Options

src/rpc/server_util.cpp

Loading...