Paths

Table of Contentst

Differential D12708

[net processing] Add IsBlockRequested() function
ClosedPublic
Actions

Authored by PiRK on Nov 30 2022, 16:39.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC3b44c0d0a4b8: [net processing] Add IsBlockRequested() function

Summary

MarkBlockAsReceived() should not be used for both removing the block
from mapBlocksInFlight and checking whether it was in the map.

This is a partial backport of core#22141
https://github.com/bitcoin/bitcoin/pull/22141/commits/62993507336be06490b202b3955d4830a99e9e34

Depends on D12707

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 30 2022, 16:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2022, 16:39

PiRK requested review of this revision.Nov 30 2022, 16:39

teamcity edited the summary of this revision. (Show Details)Nov 30 2022, 16:39

PiRK added a child revision: D12709: [net processing] Tidy up MarkBlockAsReceived().Nov 30 2022, 16:40

Harbormaster completed remote builds in B21283: Diff 36838.Nov 30 2022, 17:28

sdulfari accepted this revision.Nov 30 2022, 17:46

This revision is now accepted and ready to land.Nov 30 2022, 17:46

Closed by commit rABC3b44c0d0a4b8: [net processing] Add IsBlockRequested() function (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyDec 1 2022, 07:46

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC3b44c0d0a4b8: [net processing] Add IsBlockRequested() function.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

34 lines

Diff 36857

src/net_processing.cpp

Loading...