Page MenuHomePhabricator
Differential D12739

test: USDT tracepoint interface tests
ClosedPublic
Actions

Authored by Fabien on Dec 2 2022, 20:36.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC7415dd1f910d: test: USDT tracepoint interface tests
Summary
This adds functional tests for the USDT tracepoints added in #22006 and #22902. This partially fixes #23296. The tests are probably skipped on most systems as these tests require:

    a Linux system with a kernel that supports BPF (and available kernel headers)
    that Bitcoin Core is compiled with tracepoints for USDT support (default when compiled with depends)
    bcc installed
    the tests are run with a privileged user that is able to e.g. do BPF syscalls and load BPF maps

Backport of core#24358 and core#25528 for the test fixes.

Depends on D12737.

Note that:

  • We don't run it on CI (yet)
  • We need to prune more blocks to trigger the expected flush event as our block files are smaller
  • The 3 tests succeed on my machine, but the runner returns an error because I got compilation warnings that print to stderr
Test Plan

With tracing enabled:

sudo ./test/functional/test_runner.py interface_usdt_net
sudo ./test/functional/test_runner.py interface_usdt_utxocache
sudo ./test/functional/test_runner.py interface_usdt_validation

ninja check-functional

Check the tests are skipped as expected when not run as root.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 2 2022, 20:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 2 2022, 20:36
Fabien requested review of this revision.Dec 2 2022, 20:36
teamcity edited the summary of this revision. (Show Details)Dec 2 2022, 20:36
Harbormaster completed remote builds in B21331: Diff 36921.Dec 2 2022, 20:46
PiRK requested changes to this revision.Dec 3 2022, 16:03
PiRK added a subscriber: PiRK.
PiRK added inline comments.
test/functional/interface_usdt_utxocache.py
7 ↗(On Diff #36921)

This should probably be changed to the Bitcoin ABC url, as the API is a bit different for the type of the coin value.

This revision now requires changes to proceed.Dec 3 2022, 16:03
Fabien updated this revision to Diff 36952.Dec 4 2022, 13:06

Fix the url. I'll fix the doc (wrong amount type) in a follow-up

Harbormaster completed remote builds in B21352: Diff 36952.Dec 4 2022, 13:21
PiRK accepted this revision.Dec 5 2022, 07:08
This revision is now accepted and ready to land.Dec 5 2022, 07:08
Closed by commit rABC7415dd1f910d: test: USDT tracepoint interface tests (authored by Fabien). · Explain WhyDec 5 2022, 09:18
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC7415dd1f910d: test: USDT tracepoint interface tests.

Revision Contents
Changeset List

PathSize
test/
1 line
functional/
173 lines
423 lines
132 lines
test_framework/
30 lines

Diff 36986

View Options

test/config.ini.cmake.in

Loading...
View Options

test/functional/interface_usdt_net.py

Loading...
View Options

test/functional/interface_usdt_utxocache.py

Loading...
View Options

test/functional/interface_usdt_validation.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...