Page MenuHomePhabricator
Differential D12747

Move ChainImpl from interfaces/chain.cpp to node/interfaces.cpp
ClosedPublic
Actions

Authored by PiRK on Dec 4 2022, 10:36.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe6218ceced92: Move ChainImpl from interfaces/chain.cpp to node/interfaces.cpp
Summary

No changes to ChainImpl or any related classes (review with git diff --color-moved=dimmed_zebra)

Also remove unused includes.

This is a partial backport of core#20494
https://github.com/bitcoin/bitcoin/pull/20494/commits/2a26771d8161d30be1853a35acfee588cce03634

Depends on D12746

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 4 2022, 10:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 4 2022, 10:36
PiRK requested review of this revision.Dec 4 2022, 10:36
teamcity edited the summary of this revision. (Show Details)Dec 4 2022, 10:36
PiRK added a child revision: D12748: Move WalletImpl from interfaces/wallet.cpp to wallet/interfaces.cpp.Dec 4 2022, 10:37
PiRK added inline comments.Dec 4 2022, 10:42
src/node/interfaces.cpp
25 ↗(On Diff #36942)

Needed for DEFAULT_ANCESTOR_LIMIT... etc
Core has these constants in policy/policy.h

46 ↗(On Diff #36942)

unused

Harbormaster completed remote builds in B21343: Diff 36942.Dec 4 2022, 10:55
Fabien accepted this revision.Dec 4 2022, 13:19
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/node/interfaces.cpp
623 ↗(On Diff #36942)
766 ↗(On Diff #36942)
This revision is now accepted and ready to land.Dec 4 2022, 13:19
PiRK updated this revision to Diff 36982.Dec 5 2022, 07:48

clang-tidy style named parameters

Harbormaster completed remote builds in B21377: Diff 36982.Dec 5 2022, 08:05
Closed by commit rABCe6218ceced92: Move ChainImpl from interfaces/chain.cpp to node/interfaces.cpp (authored by PiRK). · Explain WhyDec 5 2022, 09:09
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe6218ceced92: Move ChainImpl from interfaces/chain.cpp to node/interfaces.cpp.

Revision Contents
Changeset List

PathSize
src/
1 line
interfaces/
node/
470 lines

Diff 36984

View Options

src/CMakeLists.txt

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/node/interfaces.cpp

Loading...