Page MenuHomePhabricator
Differential D12760

[Cashtab] [no BigNumber in indexedDb p2/2] Remove debug logging
ClosedPublic
Actions

Authored by bytesofman on Dec 5 2022, 00:01.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC965130e5efd4: [Cashtab] [no BigNumber in indexedDb p2/2] Remove debug logging
Summary

T2836, T2614

Depends on D12759

Remove dev logs used in test plan of previous diff in stack

Test Plan

Confirm this diff is only removing console.log statements
npm start
Switch between wallets with token balances
Send an eToken tx
Receive an eToken tx and confirm incoming notifications work

Diff Detail

Repository
rABC Bitcoin ABC
Branch
only-strings-to-indexeddb
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21376
Build 42402: Build Diffcashtab-tests
Build 42401: arc lint + arc unit

Event Timeline

bytesofman created this revision.Dec 5 2022, 00:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 5 2022, 00:01
bytesofman requested review of this revision.Dec 5 2022, 00:01
bytesofman mentioned this in D12757: [Cashtab] Store token balances as string and not BigNumber p2/2.Dec 5 2022, 00:01
Harbormaster completed remote builds in B21368: Diff 36969.Dec 5 2022, 00:04
bytesofman updated this revision to Diff 36978.Dec 5 2022, 04:06

rebase

Harbormaster completed remote builds in B21374: Diff 36978.Dec 5 2022, 04:09
bytesofman updated this revision to Diff 36981.Dec 5 2022, 04:51

rebase

Harbormaster completed remote builds in B21376: Diff 36981.Dec 5 2022, 04:55
bytesofman updated this revision to Diff 36993.Dec 5 2022, 11:26

rebase

Harbormaster completed remote builds in B21382: Diff 36993.Dec 5 2022, 11:32
emack accepted this revision.Dec 5 2022, 11:55
This revision is now accepted and ready to land.Dec 5 2022, 11:55
Closed by commit rABC965130e5efd4: [Cashtab] [no BigNumber in indexedDb p2/2] Remove debug logging (authored by bytesofman). · Explain WhyDec 5 2022, 12:37
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC965130e5efd4: [Cashtab] [no BigNumber in indexedDb p2/2] Remove debug logging.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
utils/
5 lines
1 line

Diff 36981

View Options

web/cashtab/src/utils/cashMethods.js

Loading...
View Options

web/cashtab/src/utils/chronik.js

Loading...