Page MenuHomePhabricator
Differential D12777

Add a new RPC command: restorewallet
ClosedPublic
Actions

Authored by PiRK on Dec 6 2022, 12:40.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCae9be5ea854a: Add a new RPC command: restorewallet
Summary

Change the wallet_backup.py test to use the restorewallet RPC command instead of restoring wallets manually.

This is a backport of core#22541

Depends on D12776

Minor differences from source material are caused by the missing std::filesystem backport

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 6 2022, 12:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 6 2022, 12:40
PiRK requested review of this revision.Dec 6 2022, 12:40
teamcity edited the summary of this revision. (Show Details)Dec 6 2022, 12:40
PiRK added a child revision: D12778: MOVEONLY: Move wallet backup and encryption RPCs out of rpcwallet.Dec 6 2022, 12:42
Harbormaster completed remote builds in B21402: Diff 37024.Dec 6 2022, 12:57
Fabien requested changes to this revision.Dec 6 2022, 13:36
Fabien added a subscriber: Fabien.

This deserves a release note

This revision now requires changes to proceed.Dec 6 2022, 13:36
PiRK updated this revision to Diff 37031.Dec 6 2022, 14:46

add a release note

Harbormaster completed remote builds in B21407: Diff 37031.Dec 6 2022, 15:02
Fabien accepted this revision.Dec 6 2022, 16:37
This revision is now accepted and ready to land.Dec 6 2022, 16:37
Closed by commit rABCae9be5ea854a: Add a new RPC command: restorewallet (authored by lsilva01 <lsilva01@protonmail.com>, committed by PiRK). · Explain WhyDec 7 2022, 12:15
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCae9be5ea854a: Add a new RPC command: restorewallet.

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
rpc/
1 line
wallet/
141 lines
test/
functional/
68 lines

Diff 37045

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/wallet_backup.py

Loading...