Page MenuHomePhabricator
Differential D12783

Rename sigOps to sigChecks in txmempool
ClosedPublic
Actions

Authored by Fabien on Dec 7 2022, 10:32.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC93b07dd3e73d: Rename sigOps to sigChecks in txmempool
Summary

We don't use sigops anymore, so update the variable names and comments accordingly.

There is no change in behavior.

Test Plan
ninja all check-all
ninja bitcoin-fuzzed # make sure it's not broken

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 7 2022, 10:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2022, 10:32
Fabien requested review of this revision.Dec 7 2022, 10:32
Harbormaster completed remote builds in B21414: Diff 37043.Dec 7 2022, 10:47
Fabien added a child revision: D12785: Rename sigOps to sigCheks in the miner.Dec 7 2022, 12:41
PiRK requested changes to this revision.Dec 7 2022, 14:21
PiRK added a subscriber: PiRK.
PiRK added inline comments.
src/node/miner.cpp
304 ↗(On Diff #37043)

The CBlockTemplateEnty member is still called sigOpCount.

This revision now requires changes to proceed.Dec 7 2022, 14:21
PiRK accepted this revision.Dec 7 2022, 14:23

nvm, I see that you have more diffs open.

This revision is now accepted and ready to land.Dec 7 2022, 14:23
Closed by commit rABC93b07dd3e73d: Rename sigOps to sigChecks in txmempool (authored by Fabien). · Explain WhyDec 7 2022, 16:26
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC93b07dd3e73d: Rename sigOps to sigChecks in txmempool.

Revision Contents
Changeset List

PathSize
src/
node/
6 lines
14 lines
test/
62 lines
util/
8 lines
4 lines
31 lines
80 lines

Diff 37062

View Options

src/node/miner.h

Loading...
View Options

src/node/miner.cpp

Loading...
View Options

src/test/mempool_tests.cpp

Loading...
View Options

src/test/util/setup_common.h

Loading...
View Options

src/test/util/setup_common.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...