Paths

Table of Contentst

Differential D12798

rpc: Replace boost::variant with std::variant for RPCArg.m_fallback
ClosedPublic
Actions

Authored by PiRK on Dec 7 2022, 16:45.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC7fa8ab5c9e5b: rpc: Replace boost::variant with std::variant for RPCArg.m_fallback

Summary

This is a backport of core#20736

Depends on D12797

Test Plan

With UBSAN
ninja && ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21432
Build 42514: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 42513: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 7 2022, 16:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2022, 16:45

PiRK requested review of this revision.Dec 7 2022, 16:45

teamcity edited the summary of this revision. (Show Details)Dec 7 2022, 16:45

Harbormaster completed remote builds in B21432: Diff 37068.Dec 7 2022, 17:15

sdulfari accepted this revision.Dec 7 2022, 19:15

This revision is now accepted and ready to land.Dec 7 2022, 19:15

rebase

remove include

Harbormaster completed remote builds in B21452: Diff 37099.Dec 8 2022, 08:07

Harbormaster completed remote builds in B21454: Diff 37101.Dec 8 2022, 08:19

Closed by commit rABC7fa8ab5c9e5b: rpc: Replace boost::variant with std::variant for RPCArg.m_fallback (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyDec 9 2022, 07:24

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7fa8ab5c9e5b: rpc: Replace boost::variant with std::variant for RPCArg.m_fallback.

Revision Contents
Changeset List

Path

Size

src/

rpc/

util.h

7 lines

util.cpp

12 lines

test/

sanitizer_suppressions/

ubsan

2 lines

Diff 37068

View Options

src/rpc/util.h

View Options

src/rpc/util.cpp

View Options

test/sanitizer_suppressions/ubsan

rpc: Replace boost::variant with std::variant for RPCArg.m_fallbackClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37068

src/rpc/util.h

src/rpc/util.cpp

test/sanitizer_suppressions/ubsan

rpc: Replace boost::variant with std::variant for RPCArg.m_fallback
ClosedPublic
Actions

Revision Contents
Changeset List